Odoo Addons (MOVED TO GITHUB)

[trunk / 7.0] yaml tests disabled for stock, mrp and mrp_operation

Bug #1182515 reported by Alexandre Fayolle - camptocamp on 2013-05-21

This bug affects 5 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	Lionel Sausin - Initiatives/Numérigraphe	Odoo Addons (MOVED TO GITHUB) 7.0

Bug Description

commit 6904.2.21 disabled all the yaml tests in the stock module in july 2012. The yaml files are still there. I suppose other changes in the commit broke the tests, but this is not the correct way to make runbot green.

Related branches

lp:~openerp-dev/openobject-addons/trunk-yaml-access-rights-sgo

Merged into lp:openobject-addons at revision 8893

Martin Trigaux (OpenERP) (community): Approve on 2013-09-12

OpenERP Core Team: Pending requested 2013-05-07

Diff: 3233 lines (+1478/-388)

99 files modified

account/__openerp__.py (+1/-0)
account/test/account_customer_invoice.yml (+9/-1)
account/test/account_invoice_state.yml (+5/-0)
account/test/account_supplier_invoice.yml (+5/-0)
account/test/account_test_users.yml (+32/-0)
account/test/account_validate_account_move.yml (+5/-0)
account_voucher/__openerp__.py (+1/-0)
account_voucher/test/account_voucher.yml (+6/-0)
account_voucher/test/account_voucher_users.yml (+32/-0)
account_voucher/test/case_eur_usd.yml (+5/-0)
account_voucher/test/sales_payment.yml (+5/-0)
account_voucher/test/sales_receipt.yml (+5/-0)
crm/__openerp__.py (+1/-0)
crm/security/crm_security.xml (+1/-0)
crm/test/crm_access_group_users.yml (+31/-0)
crm/test/crm_lead_cancel.yml (+7/-4)
crm/test/crm_lead_merge.yml (+5/-3)
crm/test/crm_lead_message.yml (+5/-0)
crm/test/crm_lead_onchange.yml (+7/-4)
crm/test/crm_lead_unlink.yml (+4/-1)
crm/test/lead2opportunity2win.yml (+5/-0)
crm/test/lead2opportunity_assign_salesmen.yml (+43/-38)
crm/test/phonecalls.yml (+5/-0)
event/__openerp__.py (+1/-1)
event/security/event_security.xml (+1/-0)
event/test/process/event_draft2done.yml (+5/-0)
event/test/ui/event_users.yml (+30/-0)
hr/__openerp__.py (+1/-0)
hr/test/hr_demo.yml (+5/-0)
hr/test/hr_users.yml (+42/-0)
hr/test/open2recruit2close_job.yml (+5/-0)
hr_attendance/test/attendance_process.yml (+19/-0)
hr_holidays/security/ir_rule.xml (+7/-0)
hr_recruitment/security/hr_recruitment_security.xml (+3/-0)
hr_recruitment/test/recruitment_process.yml (+19/-1)
hr_timesheet/__openerp__.py (+1/-0)
hr_timesheet/test/hr_timesheet_demo.yml (+5/-0)
hr_timesheet/test/hr_timesheet_users.yml (+42/-0)
hr_timesheet/test/test_hr_timesheet.yml (+10/-0)
mrp/__openerp__.py (+1/-0)
mrp/mrp.py (+6/-3)
mrp/security/mrp_security.xml (+1/-0)
mrp/test/cancel_order.yml (+5/-0)
mrp/test/mrp_users.yml (+31/-0)
mrp/test/order_demo.yml (+5/-0)
mrp/test/order_process.yml (+23/-11)
mrp_operations/__openerp__.py (+1/-1)
mrp_operations/test/workcenter_operations.yml (+21/-3)
mrp_repair/__openerp__.py (+2/-1)
mrp_repair/test/mrp_repair_users.yml (+30/-0)
mrp_repair/test/test_mrp_repair_afterinv.yml (+4/-1)
mrp_repair/test/test_mrp_repair_b4inv.yml (+4/-1)
mrp_repair/test/test_mrp_repair_cancel.yml (+4/-1)
mrp_repair/test/test_mrp_repair_noneinv.yml (+4/-1)
project/security/project_security.xml (+1/-0)
project/test/project_demo.yml.THIS (+23/-0)
project/test/project_process.yml.THIS (+75/-0)
project/test/task_process.yml.THIS (+81/-0)
project_issue/__openerp__.py (+1/-0)
project_issue/test/cancel_issue.yml.THIS (+65/-0)
project_issue/test/issue_demo.yml (+6/-0)
project_issue/test/issue_process.yml (+5/-0)
project_issue/test/issue_users.yml (+30/-0)
project_issue/test/subscribe_issue.yml (+1/-1)
purchase/__openerp__.py (+1/-0)
purchase/purchase_order_demo.yml (+2/-0)
purchase/test/process/cancel_order.yml (+5/-0)
purchase/test/process/generate_invoice_from_reception.yml (+5/-0)
purchase/test/process/invoice_on_poline.yml (+6/-7)
purchase/test/process/merge_order.yml (+5/-0)
purchase/test/ui/delete_order.yml (+5/-0)
purchase/test/ui/purchase_users.yml (+30/-0)
purchase_requisition/__openerp__.py (+1/-0)
purchase_requisition/security/purchase_tender.xml (+1/-0)
purchase_requisition/test/cancel_purchase_requisition.yml (+5/-0)
purchase_requisition/test/purchase_requisition.yml (+5/-0)
purchase_requisition/test/purchase_requisition_demo.yml (+5/-0)
purchase_requisition/test/purchase_requisition_users.yml (+30/-0)
resource/__openerp__.py (+1/-0)
resource/security/ir.model.access.csv (+1/-0)
resource/security/resource_security.xml (+16/-0)
sale/__openerp__.py (+1/-0)
sale/test/cancel_order.yml (+5/-0)
sale/test/create_sale_users.yml (+30/-0)
sale/test/delete_order.yml (+5/-0)
sale/test/sale_order_demo.yml (+0/-36)
sale_stock/__openerp__.py (+2/-1)
sale_stock/test/cancel_order_sale_stock.yml (+16/-2)
sale_stock/test/picking_order_policy.yml (+24/-1)
sale_stock/test/prepaid_order_policy.yml (+4/-1)
sale_stock/test/sale_order_onchange.yml (+10/-0)
sale_stock/test/sale_stock_users.yml (+61/-0)
stock/__openerp__.py (+5/-4)
stock/security/stock_security.xml (+1/-1)
stock/stock_demo.yml (+77/-69)
stock/test/opening_stock.yml (+66/-36)
stock/test/shipment.yml (+157/-149)
stock/test/stock_report.yml (+9/-4)
stock/test/stock_users.yml (+30/-0)

lp:~numerigraphe-team/openobject-addons/7.0-stock-tests-backport

Merged into lp:openobject-addons/7.0 at revision 9956

Olivier Dony (Odoo): Approve on 2014-04-04

lp:~numerigraphe-team/ocb-addons/7.0-stock-tests-backport

Rejected for merging into lp:ocb-addons

Alexandre Fayolle - camptocamp: Needs Fixing on 2014-04-04

lp:openobject-addons/7.0

Revision history for this message

Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote on 2013-05-21:

The commit which merged 6904.2.21 into the main branch also merged the commenting out of yaml tests in mrp and mrp_operation :-(

Revision history for this message

Amit Parik (amit-parik) wrote on 2013-05-22:

Hello,

We have improved the picking object on version7. Before it was same object (stock.picking) for Incoming shipment as well as Delivery Order. On version7 we have different object for Incoming shipment(stock.picking.in) and Delivery Order(stock.picking.out) inherits from the stock.picking.

That's why based on this we need to improve the yml test case, which was remaining that's why we comment all the yml on stock objects.

You are right, we have to develop correct ymls, So I am confirming this as a low Importance.

Thank you!

Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

Elias (rtxehi) wrote on 2013-05-22:

Why are tests for OpenERP "core-functionality" set to low-prio?

I would rather say that it should be pretty high.

Revision history for this message

Peter Langenberg (peter-langenberg) wrote on 2013-05-30:

Low priority ?

Revision history for this message

Amit Parik (amit-parik) wrote on 2013-05-31:

@Peter:

Low means its not a blocking point but we need to implement this, more details would you please look at https://doc.openerp.com/v6.0/contribute/11_bug_tracker.html/#bug-management-policy.

Thank you!

Revision history for this message

Twinkle Christian(OpenERP) (tch-openerp) wrote on 2013-06-12:

Hello Alexandre,

This issue has been fixed on the above project branch on line number : 2056 .

And This will merge in trunk soon.

Thank you.

Changed in openobject-addons:
status:	Confirmed → Fix Committed

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2013-09-02:

Will it be merged ?
Lionel Sausin.

Revision history for this message

Martin Trigaux (OpenERP) (mat-openerp) wrote on 2013-09-12:

Hello,

I agree hiding the test is not the correct way to work. We have merged the above branch into trunk that refactors some tests and make them run as lower access user (so more strict test).
Thanks for the report

Changed in openobject-addons:
status:	Fix Committed → Fix Released

Revision history for this message

Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote on 2014-04-04:

#10

Still not fixed for v7!
How can we trust the WMS in production without tests?

Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) on 2014-04-04

Changed in openobject-addons:
assignee:	OpenERP R&D Addons Team 2 (openerp-dev-addons2) → Lionel Sausin - Numérigraphe (lionel-sausin)

Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) on 2014-04-04

summary:

- [trunk / 7.0] yaml tests disabled for stock module
+ [trunk / 7.0] yaml tests disabled for stock, mrp and mrp_operation

Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) on 2014-04-04

Changed in ocb-addons:
assignee:	nobody → Lionel Sausin - Numérigraphe (lionel-sausin)
importance:	Undecided → Low
status:	New → Fix Committed

Revision history for this message

Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote on 2014-04-04:

#11

Luckily the tests were fixed on the trunk soon after 7.0 was released, so a backport was easy to do. I've pushed branches and made merge proposals for addons/7.0 and ocb-addons/7.0

Olivier Dony (Odoo) (odo-openerp) on 2014-04-04