Weather Indicator

indicator-weather crashed with AttributeError in ok(): 'indicator_weather' object has no attribute 'previous_label_value'

Bug #1184802 reported by Ursula Junque on 2013-05-27

152

This bug affects 32 people

Affects		Status	Importance	Assigned to	Milestone
	Weather Indicator	Fix Released	High	Joshua Tasker	Weather Indicator 13.05.26 "Rainy 3"

Bug Description

I'm running the 13.05.17 version on 12.04, I've downloaded 13.05.17 directly from launchpad, branched python-weather-api (revno. 109), and built their packages. I did this as it's impossible to add locations with the current archive version (bug 821233).

The locations all added ok, I can see them listed when clicking the weather icon. This error happened when I clicked Ok after adding all the locations (despite of the error, the window closed and the locations were there). I chose the Weather.com provider.

ProblemType: Crash
DistroRelease: Ubuntu 12.04
Package: indicator-weather 13.05.17~quantal2
ProcVersionSignature: Ubuntu 3.5.0-31.52~precise1-generic 3.5.7.11
Uname: Linux 3.5.0-31-generic i686
ApportVersion: 2.0.1-0ubuntu17.2
Architecture: i386
CrashCounter: 1
CrashDB: indicator_weather
Date: Mon May 27 20:12:23 2013
ExecutablePath: /usr/bin/indicator-weather
InstallationMedia: Ubuntu 12.04.2 LTS "Precise Pangolin" - Release i386 (20130213)
InterpreterPath: /usr/bin/python2.7
MarkForUpload: True
PackageArchitecture: all
ProcCmdline: /usr/bin/python /usr/bin/indicator-weather
ProcEnviron:
TERM=xterm
SHELL=/bin/bash
PATH=(custom, no user)
LANG=en_US.UTF-8
PythonArgs: ['/usr/bin/indicator-weather']
SourcePackage: indicator-weather
ThirdParty: True
Title: indicator-weather crashed with AttributeError in ok(): 'indicator_weather' object has no attribute 'previous_label_value'
Traceback:
Traceback (most recent call last):
File "/usr/bin/indicator-weather", line 2204, in ok
wi.update_label(wi.previous_label_value)
AttributeError: 'indicator_weather' object has no attribute 'previous_label_value'
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

See original description

Tags:

Revision history for this message

Ursula Junque (ursinha) wrote on 2013-05-27:

Dependencies.txt Edit (4.2 KiB, text/plain; charset="utf-8")
IndicatorLog.txt Edit (22.7 KiB, text/plain; charset="utf-8")
ProcMaps.txt Edit (34.4 KiB, text/plain; charset="utf-8")
ProcStatus.txt Edit (802 bytes, text/plain; charset="utf-8")
Settings.txt Edit (1.9 KiB, text/plain; charset="utf-8")

Ursula Junque (ursinha) on 2013-05-27

description:

updated

Revision history for this message

Joshua Tasker (jtasker) wrote on 2013-05-28:

I can't reproduce this. Please cut and paste the output from running this command in a terminal:

python -c "import pywapi;print pywapi.get_loc_id_from_weather_com('Campinas, São Paulo, Brazil');"

Also please give the output when you run the command 'locale' in a terminal.

Revision history for this message

Ursula Junque (ursinha) wrote on 2013-05-28:

Sure.

ursula@galactica: ~ $ python -c "import pywapi;print pywapi.get_loc_id_from_weather_com('Campinas, São Paulo, Brazil');"
{'count': 0}

ursula@galactica: ~ $ locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=

Joshua Tasker (jtasker) on 2013-05-29

Changed in weather-indicator:
status:	New → In Progress

Revision history for this message

Joshua Tasker (jtasker) wrote on 2013-05-29:

lp1184802.patch Edit (718 bytes, text/plain)

I think I have fixed the problem, please try this patch and let me know if the issue still exists.

Revision history for this message

Joshua Tasker (jtasker) wrote on 2013-05-29:

Also, please update to 13.05.25~quantal3 before you run the patch. You can get the tarball here:
https://launchpad.net/weather-indicator/+milestone/13.05.25
or you can get a package via the ppa, just add 'ppa:/weather-indicator-team/ppa' to your software sources.

Joshua Tasker (jtasker) on 2013-05-29

Changed in weather-indicator:
milestone:	none → 13.05.26
importance:	Undecided → High
assignee:	nobody → Joshua Tasker (jtasker)

Revision history for this message

Ursula Junque (ursinha) wrote on 2013-05-29:

Hi Joshua! I installed the pristine 13.05.25 version and wasn't able to reproduce the problem. After that I applied the patch, built the package and installed again, wasn't able to reproduce it either. Not sure it was a spurious problem or the 13.05.25 version fixed that already. Please, just let me know if there is anything else I can do.

Thanks!

Úrsula

Revision history for this message

Joshua Tasker (jtasker) wrote on 2013-05-29:

Great! I am marking this issue as 'Fixed'.