Ubuntu
software-properties package

in-line comment appears as a source preceded by whitespace

Bug #1185144 reported by Brian Murray
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-properties (Ubuntu)
Fix Released
Low
Robert Roth

Bug Description

I have the following line in my /etc/apt/sources.list file:

deb-src http://192.168.10.1/ubuntu/ precise main restricted universe multiverse # this too is an in-line comment

This ends up creating another sources line in the "Other Software" tab that says:

' this too is an in-line comment'

See the attached screenshot for details.

ProblemType: Bug
DistroRelease: Ubuntu 13.04
Package: software-properties-gtk 0.92.17
ProcVersionSignature: Ubuntu 3.8.0-19.30-generic 3.8.8
Uname: Linux 3.8.0-19-generic x86_64
ApportVersion: 2.9.2-0ubuntu8.1
Architecture: amd64
Date: Tue May 28 11:55:56 2013
EcryptfsInUse: Yes
InstallationDate: Installed on 2013-01-16 (132 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Alpha amd64 (20130116)
MarkForUpload: True
PackageArchitecture: all
SourcePackage: software-properties
UpgradeStatus: No upgrade log present (probably fresh install)

See original description

Related branches

lp:~evfool/software-properties/trim-source-comment
Iain Lane: Approve
Brian Murray: Approve
Diff: 12 lines (+1/-1)
1 file modified
softwareproperties/SoftwareProperties.py (+1/-1)
lp:ubuntu/saucy-proposed/software-properties
Revision history for this message
Brian Murray (brian-murray) wrote :
Revision history for this message
Robert Roth (evfool) wrote :

Thanks for the report, but this I'd consider a feature: comments are there to provide user-friendly descriptions of repositories, and software-properties-gtk just displays the user-friendly description first. Consider a real use-case, you would comment a repository e.g. with Local quantal repository, and that's what you would see there instead of 192.168.0.1......, that makes sense to me.

What would you like to see there?

Changed in software-properties (Ubuntu):
status: New → Incomplete
Revision history for this message
Brian Murray (brian-murray) wrote :

Okay, I understand the purpose behind this now and it makes sense. One thing to note is that the line "this too is an in-line comment" is preceded by a space in software-properties, surely because my comment starts "# this too" . Perhaps a strip of the comment would be a good idea.

Revision history for this message
Robert Roth (evfool) wrote :

Agreed on that, stripping is a good idea. I'll propose a review with that, it's an easy one.

Changed in software-properties (Ubuntu):
status: Incomplete → Triaged
summary: - in-line comment appears as a source
+ in-line comment appears as a source preceded by whitespace
description: updated
Robert Roth (evfool)
Changed in software-properties (Ubuntu):
assignee: nobody → Robert Roth (evfool)
status: Triaged → In Progress
Robert Roth (evfool)
Changed in software-properties (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.92.21

---------------
software-properties (0.92.21) saucy; urgency=low

  * Copy software-properties icon from Humanity (and Elementary)
    to replace the dated and unclear icon used if your icon theme doesn't
    include a replacement icon
 -- Jeremy Bicha <email address hidden> Mon, 24 Jun 2013 14:15:40 +0200

Changed in software-properties (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.