[6.1] File upload broken on Firefox 22
Bug #1197783 reported by
Yves Bolognini @ camptocamp
This bug affects 10 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Web (MOVED TO GITHUB) |
Fix Released
|
Undecided
|
OpenERP Publisher's Warranty Team | ||
| OpenERP Community Backports (Web) |
Fix Released
|
Medium
|
Stefan Rijnhart (Opener) | ||
| 6.1 |
Fix Released
|
Medium
|
Stefan Rijnhart (Opener) | ||
Bug Description
Can't upload a file on OpenERP 6.1.
Steps to reproduce:
- Use Firefox 22
- http://
- Settings/
- Select any file
- Open
- Uploading... and nothing happens
Using Firefox 22 on Ubuntu. Same bug reported on Firefox 22 / Mac.
Using latest runbot 6.1 version:
(Build 15172)
server (4358)
addons (7233)
web (2516)
Related branches
lp:~therp-nl/openerp-web/6.1-lp1197783-file_upload_firefox_22
- Lorenzo Battistini (community): Approve (tested on customers)
- Holger Brunn (Therp) (community): Approve (code review)
- OpenERP Core Team: Pending requested
-
Diff: 68 lines (+9/-6)3 files modifiedaddons/web/controllers/main.py (+1/-1)
addons/web/static/src/js/view_form.js (+2/-2)
addons/web/static/src/xml/base.xml (+6/-3)
lp:~therp-nl/ocb-web/6.1-lp1197783-file_upload_firefox_22
- Holger Brunn (Therp): Approve (code review)
-
Diff: 68 lines (+9/-6)3 files modifiedaddons/web/controllers/main.py (+1/-1)
addons/web/static/src/js/view_form.js (+2/-2)
addons/web/static/src/xml/base.xml (+6/-3)
lp:~openerp-dev/openerp-web/6.1-staging-mat
- Martin Trigaux (OpenERP): Pending requested
- Diff: 0 lines
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | #1 |
| Changed in ocb-web: | |
| assignee: | nobody → Stefan Rijnhart (Therp) (stefan-therp) |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in openerp-web: | |
| assignee: | nobody → OpenERP Publisher's Warranty Team (openerp-opw) |
| tags: | added: maintenance |
Revision history for this message
| Stéphane Bidoul (Acsone) (sbi) wrote | #2 |
Revision history for this message
| Raphaël Valyi - http://www.akretion.com (rvalyi) wrote Re: [Bug 1197783] Re: [6.1] File upload broken on Firefox 22 | #3 |
Revision history for this message
| Martin Trigaux (OpenERP) (mat-openerp) wrote | #4 |
| Changed in ocb-web: | |
| status: | Confirmed → Fix Released |
| Changed in openerp-web: | |
| status: | New → Fix Released |
To post a comment you must log in.
Confirmed. In our analysis, the callback function is stored in the DOM on an iframe element. However, this iframe element is also the target of the snippet of javascript that retrieves the callback function and calls it. In Firefox 22, when the snippet is loaded into the iframe, the iframe element no longer contains the callback. Additionally, the error message that is supposed to indicate this to the user does not function properly.
We have an ugly, 2 line proof of concept fix that stores the callback function in another place. Hopefully we will have an acceptable solution later today.