embed pdf not showing link when js turned off

Bug #1211070 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

Embedded pdfs on a page added with the Embed PDF blocktype (see: https://bugs.launchpad.net/mahara/+bug/1036556) do not display the download link if javascript is turned off.

To replicate:
1) install latest core mahara.
2) embed some pdfs into a page by going to Portfolio -> pages and add a new page. Drag in the pdf block and upload a pdf via it's config interface. This should display the pdf in the page and allow you to download by it's toolbar option.
3) disable javascript for the page and reload it. The pdfviewer does not show (which is expected as it is js driven) but there also is no link to download the pdf.

Apply patchset and now you should be presented with a link to the file when javascript is turned off

Tags: viewaccess pdf
Revision history for this message
Robert Lyon (robertl-9) wrote :

Have submitted a patch to fix this:
 https://reviews.mahara.org/#/c/2397/

Aaron Wells (u-aaronw)
tags: added: pdf
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.