[Calculator app] Top label underline is too long
Bug #1219718 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Calculator App |
Fix Released
|
Low
|
Riccardo Padovani | ||
| Ubuntu UX |
Fix Released
|
Undecided
|
Michal Izydorczyk | ||
Bug Description
Please see Bug 1214395 for updated designs and comments on the behaviour of the labelling. This has changed.
=======
When I edit a calculation's top label, the underline spans across the whole screen on the right. See the attached screenshot.
I believe it should at least have a right margin equal to that of the operands below.
Related branches
lp:~rpadovani/ubuntu-calculator-app/1214395
- Gustavo Pichorim Boiko (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Nekhelesh Ramananthan (community): Needs Information
- Mihir Soni: Needs Fixing
-
Diff: 584 lines (+79/-200)9 files modifiedSimple/CalcKeyboard.qml (+0/-1)
Simple/CalcLabel.qml (+14/-35)
Simple/KeyboardButton.qml (+0/-1)
Simple/Screen.qml (+27/-30)
Simple/SimplePage.qml (+8/-17)
Storage.qml (+5/-2)
bignumber.js (+9/-8)
dateutils.js (+0/-99)
engine.js (+16/-7)
Revision history for this message
| David Planella (dpm) wrote | #1 |
| tags: | added: needs-design |
| Changed in ubuntu-calculator-app: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| milestone: | none → coreapps-13.10-beta |
| summary: |
- Top label underline is too long + [Calculator app] Top label underline is too long |
| description: | updated |
| Changed in ubuntu-calculator-app: | |
| assignee: | nobody → Howard Chan (smartboyhw) |
| status: | Triaged → In Progress |
Revision history for this message
| Christina Li (christina-li) wrote | #2 |
| Changed in ubuntu-ux: | |
| assignee: | nobody → Michal Izydorczyk (iamfhero) |
Revision history for this message
| Michal Izydorczyk (iamfhero) wrote | #3 |
Revision history for this message
| Christina Li (christina-li) wrote | #4 |
| Changed in ubuntu-ux: | |
| status: | New → Fix Committed |
| description: | updated |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Invalid |
| status: | Invalid → Fix Committed |
| Changed in ubuntu-calculator-app: | |
| assignee: | Howard Chan (smartboyhw) → Riccardo Padovani (rpadovani) |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #5 |
| Changed in ubuntu-calculator-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-calculator-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Michal, can you please take a look at this bug and provide visual design input? thanks!