[7.0/Trunk] Missing 'target move' field selection on account vat declaration wizard
Bug #1220732 reported by
Frederic Clementi - Camptocamp
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Confirmed
|
Wishlist
|
OpenERP Publisher's Warranty Team | |||
| OpenERP Community Backports (Addons) | Status tracked in 7.0 | |||||
| 7.0 |
Fix Released
|
Medium
|
Yannick Vaucher @ Camptocamp | |||
Bug Description
The 'target move' field selection on the account vat declaration wizard is missing.
By default, OpenERP select posted entries only.
However, since it is not mandatory to post accounting entries before using this wizard, vat report generated can be wrong.
I suggest to add the 'target move' field selection so the user can decide to includes or not the draft entries.
(see printscreen)
Thanks
Frederic Clementi
Camptocamp
Related branches
lp:~camptocamp/ocb-addons/tax_report_draft_posted_sum
- Yannick Vaucher @ Camptocamp: Disapprove
- Stefan Rijnhart (Opener): Needs Fixing
- Holger Brunn (Therp): Approve (code review)
-
Diff: 17 lines (+5/-1)1 file modifiedaccount/report/account_tax_report.py (+5/-1)
lp:~camptocamp/ocb-addons/7.0-fix-1220732
- Stefan Rijnhart (Opener): Approve
- Holger Brunn (Therp): Approve (code review)
- Nicolas Bessi - Camptocamp (community): Needs Fixing (code review, no test)
-
Diff: 100 lines (+21/-8)3 files modifiedaccount/report/account_tax_report.py (+15/-6)
account/report/account_tax_report.rml (+5/-2)
account/wizard/account_vat_view.xml (+1/-0)
lp:~openerp-dev/openobject-addons/7.0-opw-597492-pna
- Yannick Vaucher @ Camptocamp (community): Needs Fixing
- Naresh(OpenERP): Pending requested
-
Diff: 100 lines (+21/-8)3 files modifiedaccount/report/account_tax_report.py (+15/-6)
account/report/account_tax_report.rml (+5/-2)
account/wizard/account_vat_view.xml (+1/-0)
Revision history for this message
| Frederic Clementi - Camptocamp (frederic-clementi) wrote | #1 |
| Changed in openobject-addons: | |
| assignee: | nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3) |
| importance: | Undecided → Wishlist |
| status: | New → Confirmed |
| Changed in openobject-addons: | |
| assignee: | OpenERP R&D Addons Team 3 (openerp-dev-addons3) → OpenERP Publisher's Warranty Team (openerp-opw) |
| tags: | added: maintenance |
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | #2 |
To post a comment you must log in.
Hi, I think you shouldn't change signature of the methods to avoid side effects on other code that uses this method. I know that the method is private, but usually you have been calling private methods in other modules. In fact, we are using one of these methods (_get_lines) in Spain to get a tax report easily and without reinventing wheel.
I think you can fix it easily simply putting a default value (None or False) to the new argument and handling this possible default value where needed. In this way, you don't need double code for calling this function in other conditions.
Regards.