Merge quodlibet-plugins (20070625-1) from debian unstable

Bug #123610 reported by Andrea Veri
6
Affects Status Importance Assigned to Milestone
quodlibet-plugins (Ubuntu)
Fix Released
Wishlist
Emmet Hikory

Bug Description

Binary package hint: quodlibet-plugins

Debdiff attached.

Revision history for this message
Andrea Veri (av) wrote :
Changed in quodlibet-plugins:
status: New → Confirmed
Revision history for this message
Adrien Cunin (adri2000) wrote :

+ - Dropping 01_gajim-attribute-error.dpatch previously added, removing
+ everything dpatch related. This fix has been integrated in the new upstream
+ svn snapshot packaged in debian. See debian bug #429063.

That's not an Ubuntu change.
Put it rather in a new *, saying that you removed the dpatch stuff.

Changed in quodlibet-plugins:
status: Confirmed → Incomplete
Revision history for this message
Emmet Hikory (persia) wrote :

Two things confuse me about this bug. I have unsubscribed ubuntu-universe-sponsors pending clarification of these points.

1) Why is this bug Incomplete, yet in queue? If it was marked Incomplete, it should be pulled from queue. If the comment was reviewed, and it was returned to the queue, the status should be updated.

2) It appears to me that dpatch was added in 20070529-1ubuntu2 as an ubuntu change (in contravention of accepted guidelines). Is this not an Ubuntu change? Has Debian later adopted dpatch? If Debian has adopted dpatch, why is it being removed? If dpatch is used, would that not be a better place for the "Do not specify universal newline" patch?

Separately, this bug does not follow the suggested format for merge bugs: the interim Debian changelog should be included as part of the description, so as to ease reviewing what changes would be introduced by the merge.

Revision history for this message
Andrea Veri (av) wrote :

the bugfix has been integrated in the new svn snapshot, so debian did not introduce dpatch, that's why the dpatch system is no more needed.
debian changelog's entry is:

quodlibet-plugins (20070625-1) unstable; urgency=low

  * New upstream svn snapshot.
    - Gajim plugin bugfixes. (Closes: #429063)

 -- Christine Spang <email address hidden> Mon, 25 Jun 2007 17:22:24 -0400

Debdiff ok now.

Changed in quodlibet-plugins:
status: Incomplete → Confirmed
Revision history for this message
Andrea Veri (av) wrote :

Re-adding it, seems it has been uploaded in html.

Revision history for this message
Emmet Hikory (persia) wrote :

Thanks for the explanation, but I'm still not sure this is right. You say above "...debian did not introduce dpatch, that's why the dpatch system is no more needed.", but you list as a new change "...dropping 01_gajim-attribute-error.dpatch previously added, removing everything dpatch related...". If it's not a Debian change, and it's not a maintained Ubuntu change, I don't think you need a changelog entry. You may wish to also seek alternate opinions in #ubuntu-motu. Also, remember to subscribe ubuntu-universe-sponsors to request upload.

Revision history for this message
Emmet Hikory (persia) wrote :

Thanks. Unfortunately, the patch didn't apply. Please respin against quodlibet_1.0-1.

Changed in quodlibet-plugins:
assignee: nobody → persia
status: Confirmed → In Progress
assignee: persia → bluekuja
importance: Undecided → Wishlist
status: In Progress → Incomplete
Revision history for this message
Emmet Hikory (persia) wrote :

Rather, I failed to apply the patch to the correct package. Uploaded.

Changed in quodlibet-plugins:
assignee: bluekuja → persia
status: Incomplete → In Progress
status: In Progress → Fix Committed
William Grant (wgrant)
Changed in quodlibet-plugins:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.