maas and curtin do not indicate failure reasonably
Bug #1237215 reported by
Adam Stokes
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Newell Jensen | ||
| curtin |
Fix Released
|
Medium
|
Newell Jensen | ||
Bug Description
Adam had an issue where curtin was failing installation (due to bug 1236544), but he didn't know why. He reported it as failed running of late commands, but the late commands were not being run because curtin was failing and stopping execution.
There is no clear evidence of that on console or in maas in any way.
We really need to improve curtin and maas integration to get logging going back to maas syslog, and also make curtin clear on the console that something has gone wrong.
Related branches
lp:~newell-jensen/maas/maas-metadataserver-curtin-install-log
- Blake Rouse (community): Approve
-
Diff: 1145 lines (+385/-133)20 files modifiedsrc/maasserver/api.py (+17/-9)
src/maasserver/models/node.py (+2/-2)
src/maasserver/models/nodeprobeddetails.py (+4/-3)
src/maasserver/models/tests/test_node.py (+9/-6)
src/maasserver/testing/factory.py (+5/-3)
src/maasserver/tests/test_api_nodegroup.py (+8/-5)
src/maasserver/tests/test_third_party_drivers.py (+4/-3)
src/maasserver/third_party_drivers.py (+1/-1)
src/maasserver/views/nodecommissionresult.py (+4/-4)
src/maasserver/views/nodes.py (+2/-2)
src/maasserver/views/tests/test_nodecommissionresults.py (+3/-3)
src/metadataserver/api.py (+50/-30)
src/metadataserver/enum.py (+21/-8)
src/metadataserver/migrations/0015_rename_nodecommissionresult_add_result_type.py (+179/-0)
src/metadataserver/models/__init__.py (+3/-3)
src/metadataserver/models/commissioningscript.py (+6/-4)
src/metadataserver/models/noderesult.py (+30/-15)
src/metadataserver/models/tests/test_nodecommissionresult.py (+24/-21)
src/metadataserver/models/tests/test_noderesults.py (+4/-2)
src/metadataserver/tests/test_api.py (+9/-9)
lp:~newell-jensen/maas/maas-maasserver-ui-curtin-install-log
- Blake Rouse (community): Approve
-
Diff: 676 lines (+304/-75)11 files modifiedsrc/maasserver/api/results.py (+3/-3)
src/maasserver/api/tests/test_commissioning.py (+4/-4)
src/maasserver/templates/maasserver/node_view.html (+28/-10)
src/maasserver/templates/metadataserver/nodeinstallresult.html (+35/-0)
src/maasserver/testing/factory.py (+16/-0)
src/maasserver/urls.py (+10/-5)
src/maasserver/urls_api.py (+7/-4)
src/maasserver/views/noderesult.py (+25/-7)
src/maasserver/views/nodes.py (+11/-4)
src/maasserver/views/tests/test_noderesult.py (+92/-25)
src/maasserver/views/tests/test_nodes.py (+73/-13)
lp:~newell-jensen/curtin/install-log-reporter
- Blake Rouse (community): Approve
-
Diff: 551 lines (+381/-28)5 files modifiedcurtin/commands/install.py (+50/-16)
curtin/reporter/__init__.py (+78/-0)
curtin/reporter/maas.py (+227/-0)
curtin/util.py (+25/-11)
setup.py (+1/-1)
Revision history for this message
| Adam Stokes (adam-stokes) wrote | #1 |
Revision history for this message
| Raphaël Badin (rvb) wrote | #2 |
| summary: |
- late_commands in maas provision node fails + maas and curtin do not indicate failure reasonably |
| description: | updated |
| description: | updated |
| Changed in maas: | |
| status: | New → Confirmed |
| Changed in curtin: | |
| status: | New → Confirmed |
| Changed in maas: | |
| importance: | Undecided → Medium |
| Changed in curtin: | |
| importance: | Undecided → Medium |
| Changed in maas: | |
| status: | Confirmed → Triaged |
| importance: | Medium → High |
| tags: | added: debugging |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #3 |
Revision history for this message
| Mark Duncan (eattheapple) wrote | #4 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #5 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #6 |
Revision history for this message
| Mark Duncan (eattheapple) wrote | #7 |
| Changed in maas: | |
| status: | Triaged → Fix Committed |
| Changed in maas: | |
| milestone: | none → 1.6.1 |
| Changed in maas: | |
| status: | Fix Committed → In Progress |
| tags: | added: robustness |
| Changed in maas: | |
| assignee: | nobody → Newell Jensen (newell-jensen) |
| Changed in curtin: | |
| assignee: | nobody → Newell Jensen (newell-jensen) |
Revision history for this message
| Newell Jensen (newell-jensen) wrote | #8 |
| Changed in curtin: | |
| status: | Confirmed → Fix Committed |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
| Changed in curtin: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Should note this is from cloud-tools pocket on cloud archive, here are my package versions
ubuntu@maas:~$ dpkg -l|grep maas
ii maas 1.4+bzr1656+
ii maas-cli 1.4+bzr1656+
ii maas-cluster-
ii maas-common 1.4+bzr1656+
ii maas-dhcp 1.4+bzr1656+
ii maas-dns 1.4+bzr1656+
ii maas-region-
ii python-django-maas 1.4+bzr1656+
ii python-maas-client 1.4+bzr1656+
ii python-
ubuntu@maas:~$ dpkg -l|grep curtin
ii curtin-common 0.1.0~bzr87-
ii python-curtin 0.1.0~bzr87-