wsgi smart server chrooting does not manage additional paths

Bug #124089 reported by Robert Collins
8
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Andrew Bennetts

Bug Description

smart servers requests contain embedded paths which are host relative as
the client saw it - e.g. /bzr/repo/branch
but within apache this will often be mapped to something
like /var/repos/repo/branch and thus the wsgi chroot is setup:
root=/var/repos
prefix=/bzr/

this gives us a chroot on /var/repos
however, when we parse a request from the client we get a path
of /bzr/repo/branch - giving us a local path
of /var/repos/bzr/repo/branch which clearly does not exist.

I propose that we add a convert-from-client-path call in the Request
object, to be used by anything that accepts a path from the client. It
will need the externally mapped address given to it which corresponds to
the root of the chroot (e.g. prefix above).

This makes smart server configuration appear very very hard when in fact
its a bug on our end.

 affects /products/bzr
 importance critical
 status triaged
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Tags: hpss

Related branches

Andrew Bennetts (spiv)
Changed in bzr:
assignee: nobody → spiv
Revision history for this message
John A Meinel (jameinel) wrote :

The associated branch seems to have some fixes for this. And only the last revision isn't merged.
Does that mean there is a Fix Committed, and we just need to review it? Or did it get put to the side for other fixes?

Revision history for this message
Robert Collins (lifeless) wrote :

Ping, andrew - whats the status on this branch?

Martin Pool (mbp)
Changed in bzr:
importance: Critical → High
Andrew Bennetts (spiv)
Changed in bzr:
milestone: none → 1.0alpha2
Andrew Bennetts (spiv)
Changed in bzr:
status: Triaged → Fix Committed
Andrew Bennetts (spiv)
Changed in bzr:
milestone: 1.0rc2 → 1.0rc3
Revision history for this message
Martin Pool (mbp) wrote :

spiv says: needs more work, will miss 1.0rc3

Changed in bzr:
milestone: 1.0rc3 → none
status: Fix Committed → In Progress
Revision history for this message
Martin Packman (gz) wrote :

See also Bug #119330 where I stumbled around this issue, amoung others.

John A Meinel (jameinel)
Changed in bzr:
milestone: none → 1.4
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.