Ubuntu UI Toolkit

gallery-app and notes-app test failures in trusty

Bug #1244523 reported by Timo Jyrinki on 2013-10-25

This bug affects 2 people

	Status	Importance	Assigned to
Ubuntu UI Toolkit	Invalid	Critical	Zoltan Balogh
gallery-app	Invalid	Critical	Olivier Tilloy
notes-app	Fix Released	Critical	Olivier Tilloy

Bug Description

The tests are run with ppa:ubuntu-unity/daily-build contents, reflecting the trunks of UI Toolkit and apps running on trusty. We're now still using autopilot 1.3 so the problems of the 1.4 branch should not affect this.

See http://pastebin.ubuntu.com/6298989/ for details on those tests that are run as part of the ui-toolkit cu2d autopilot run:

    gallery_app.tests.test_album_view.TestAlbumView.test_album_view_open_photo
    gallery_app.tests.test_photos_view.TestPhotosView.test_open_photo
    notes_app.tests.test_create.TestCreate.test_note_expand_and_unexpand(with mouse)

The apps stack full test run log attached as 'autopilot-apps.log'. The failing tests in full are:

    gallery_app.tests.test_album_editor.TestAlbumEditor.test_add_photo
    gallery_app.tests.test_photos_view.TestPhotosView.test_open_photo
    gallery_app.tests.test_album_view.TestAlbumView.test_album_view_open_photo
    gallery_app.tests.test_album_view.TestAlbumView.test_add_photo_to_new_album
    gallery_app.tests.test_album_editor.TestAlbumEditor.test_album_title_fields
    gallery_app.tests.test_album_editor.TestAlbumEditor.test_cover_image
    gallery_app.tests.test_album_view.TestAlbumView.test_add_photo
    notes_app.tests.test_create.TestCreate.test_note_unfocused_when_collapsed(with mouse)
    notes_app.tests.test_delete.TestDelete.test_slide_to_delete_right(with mouse)
    notes_app.tests.test_expand_collapse.TestExpandCollapse.test_expand_and_collapse_many(with mouse)
    notes_app.tests.test_images.TestImageSmallHigh.test_no_crash(with mouse)
    notes_app.tests.test_expand_collapse.TestExpandCollapse.test_collapse_bottom(with mouse)
    notes_app.tests.test_parts.TestFocus.test_parts_delete_when_empty(with mouse)
    notes_app.tests.test_parts.TestFocus.test_parts_focus(with mouse)
    notes_app.tests.test_create.TestCreate.test_note_focus_on_second_click_outside(with mouse)
    notes_app.tests.test_delete.TestDelete.test_slide_to_delete_left(with mouse)
    notes_app.tests.test_images.TestImageLargeWide.test_no_crash(with mouse)
    notes_app.tests.test_create.TestCreate.test_note_focused_when_empty(with mouse)
    notes_app.tests.test_expand_collapse.TestExpandCollapse.test_collapse_between(with mouse)
    notes_app.tests.test_expand_collapse.TestExpandCollapse.test_collapse_header(with mouse)
    notes_app.tests.test_images.TestImageSmallWide.test_no_crash(with mouse)
    notes_app.tests.test_images.TestImageLargeHigh.test_no_crash(with mouse)
    notes_app.tests.test_create.TestCreate.test_note_expand_and_unexpand(with mouse)
    notes_app.tests.test_create.TestCreate.test_note_focus_on_second_click_inside(with mouse)
    notes_app.tests.test_parts.TestFocus.test_parts_delete_empty_header(with mouse)
    notes_app.tests.test_parts.TestFocus.test_parts_no_delete_with_text(with mouse)

This bug prevents publishing of the apps and sdk stacks to trusty.

See original description

Related branches

lp:~osomon/notes-app/hide-toolbar

Merged into lp:notes-app at revision 218

PS Jenkins bot: Needs Fixing (continuous-integration) on 2013-10-31

Ubuntu Phablet Team: Pending requested 2013-10-25

lp:~osomon/gallery-app/hide-toolbar

Rejected for merging into lp:gallery-app

Olivier Tilloy: Disapprove on 2013-11-11

PS Jenkins bot: Needs Fixing (continuous-integration) on 2013-11-06

Revision history for this message

Timo Jyrinki (timo-jyrinki) wrote on 2013-10-25:

autopilot-apps.log Edit (450.6 KiB, text/plain)

summary:	- ubuntu-ui-toolkit (app) test failures in trusty + gallery-app and notes-app test failures in trusty
description:	updated
Changed in gallery-app:
importance:	Undecided → Critical
Changed in notes-app:
importance:	Undecided → Critical
Changed in ubuntu-ui-toolkit:
assignee:	nobody → Zoltan Balogh (bzoltan)
Changed in gallery-app:
assignee:	nobody → Bill Filler (bfiller)
Changed in notes-app:
assignee:	nobody → Bill Filler (bfiller)
Changed in gallery-app:
assignee:	Bill Filler (bfiller) → Olivier Tilloy (osomon)
Changed in notes-app:
assignee:	Bill Filler (bfiller) → Olivier Tilloy (osomon)

Timo Jyrinki (timo-jyrinki) on 2013-10-25

description:	updated
description:	updated

Revision history for this message

Olivier Tilloy (osomon) wrote on 2013-10-25:

I can reliably reproduce the failures for notes-app on saucy running with the latest trunks of ubuntu-ui-toolkit (rev. 807) and notes-app (rev. 216).

The same tests pass with ubuntu-ui-toolkit built from revision 800, so it seems to be a recent regression in the UITK.

Revision history for this message

Olivier Tilloy (osomon) wrote on 2013-10-25:

It appears the problem was introduced by revision 805 in the UITK. It’s not a regression per-se (as in a bug), but rather a change in the default behaviour: the toolbar is now shown by default when launching the application, and automatically hides after a fixed timeout.

So I guess one way to address this issue in the apps is to update their autopilot tests to wait for the toolbar to automatically hide before starting to interact with the app.

Olivier Tilloy (osomon) on 2013-10-25

Changed in notes-app:
status:	New → In Progress

Revision history for this message

Olivier Tilloy (osomon) wrote on 2013-10-25:

It looks like the trick I used to solve the issue in notes-app doesn’t work for gallery app. There are probably more interactions at play, and we need to ensure the toolbar is hidden in other places in the tests.

Changed in gallery-app:
status:	New → Confirmed

Olivier Tilloy (osomon) on 2013-10-25

Changed in gallery-app:
status:	Confirmed → In Progress

Olivier Tilloy (osomon) on 2013-11-01

Changed in notes-app:
status:	In Progress → Fix Committed

Revision history for this message

Timo Jyrinki (timo-jyrinki) wrote on 2013-11-08:

Marking the UI Toolkit part Invalid in case the statement still holds that it's a feature, not a bug :) Reopen if there's something still to be changed on its side.