OpenStack Core Infrastructure

Allow core reviewers restore auto-abandoned reviews

Bug #1248794 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Released
Medium
Jeremy Stanley

Bug Description

This came up in the context of https://etherpad.openstack.org/p/stable-havana-ideas but also applies more generally

If a review is auto-abandoned, often core reviewers want to pick up the work on the review under the same Change-Id without bugging the original review owner

Tags: gerrit
Revision history for this message
Jeremy Stanley (fungi) wrote :

It's worth noting that there is no ACL permission for unabandoning a change in Gerrit, so probably we want the auto-abandon script to auto-WiP instead. If so, we may also also be better off waiting until we upgrade Gerrit, since the work-in-progress implementation has not been solidified upstream yet and may change significantly.

Changed in openstack-ci:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Khai Do (zaro0508) wrote :

Ability to give groups permission to abandon a change is available in later versions of gerrit. Any group that has permission to abandon changes also has permission to restore changes. Not sure when it got added but I know it's available in gerrit version 2.7.

Khai Do (zaro0508)
Changed in openstack-ci:
assignee: nobody → Khai Do (zaro0508)
Khai Do (zaro0508)
Changed in openstack-ci:
status: Triaged → In Progress
Revision history for this message
Khai Do (zaro0508) wrote :

This use case be configured in gerrit 2.8 but needs to be done by a gerrit admin so i'm going to relinquish ownership of this issue to let a gerrit admin pickup.

Changed in openstack-ci:
assignee: Khai Do (zaro0508) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/91797

Changed in openstack-ci:
assignee: nobody → Jeremy Stanley (fungi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.openstack.org/91797
Committed: https://git.openstack.org/cgit/openstack-infra/config/commit/?id=c7d3ed29330f4baa6e80c3c2d1894bc9cd23e460
Submitter: Jenkins
Branch: master

commit c7d3ed29330f4baa6e80c3c2d1894bc9cd23e460
Author: Jeremy Stanley <email address hidden>
Date: Wed May 7 21:06:43 2014 +0000

    Allow core reviewers to abandon and unabandon

    A much awaited feature, this patch is the outcome of running:

    find modules/openstack_project/files/gerrit/acls/ \
        doc/source/stackforge.rst -type f -exec sed -i -e \
        's/^\(.* \)label-Workflow .*\(group .*\)$/\0\n\1abandon = \2/' \
        -e 's/.*exclusiveGroup.*Workflow.*/\0 abandon/' \
        {} \;

    Change-Id: I217a8689528d14c9143de5656db01549f263c3b4
    Closes-Bug: #1248794

Changed in openstack-ci:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.