PTDEBUG prints some info to STDOUT
Bug #1249150 reported by
Daniel Nichter
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter | ||
Bug Description
Alll tools have this in OptionParser.pm:
# This is debug code I want to run for all tools, and this is a module I
# certainly include in all tools, but otherwise there's no real reason to put
# it here.
if ( PTDEBUG ) {
print '# ', $^X, ' ', $], "\n";
if ( my $uname = `uname -a` ) {
$uname =~ s/\s+/ /g;
print "# $uname\n";
}
print '# Arguments: ',
join(' ', map { my $a = "_[$_]_"; $a =~ s/\n/\n# /g; $a; } @ARGV), "\n";
}
Consequently, PTDEBUG prints those lines to STDOUT instead of STDERR.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-pqd-stats-bug-1249149
- Daniel Nichter: Approve
-
Diff: 551 lines (+83/-83)27 files modifiedbin/pt-agent (+3/-3)
bin/pt-align (+3/-3)
bin/pt-archiver (+3/-3)
bin/pt-config-diff (+3/-3)
bin/pt-deadlock-logger (+3/-3)
bin/pt-diskstats (+3/-3)
bin/pt-duplicate-key-checker (+3/-3)
bin/pt-fifo-split (+3/-3)
bin/pt-find (+3/-3)
bin/pt-fingerprint (+3/-3)
bin/pt-fk-error-logger (+3/-3)
bin/pt-heartbeat (+3/-3)
bin/pt-index-usage (+3/-3)
bin/pt-kill (+3/-3)
bin/pt-online-schema-change (+3/-3)
bin/pt-query-digest (+5/-5)
bin/pt-show-grants (+3/-3)
bin/pt-slave-delay (+3/-3)
bin/pt-slave-find (+3/-3)
bin/pt-slave-restart (+3/-3)
bin/pt-table-checksum (+3/-3)
bin/pt-table-sync (+3/-3)
bin/pt-table-usage (+3/-3)
bin/pt-upgrade (+3/-3)
bin/pt-variable-advisor (+3/-3)
bin/pt-visual-explain (+3/-3)
lib/OptionParser.pm (+3/-3)
| Changed in percona-toolkit: | |
| importance: | Undecided → Medium |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/