[trunk/7.0] Editable tree view triggers error

Hello ,

Its also happen with "Logged Calls" , "Categories" and with other editable tree views . So, I am confirming this issue .

Thank you.

Right, so problem is the handler for the tab event blows up entirely at the end of the line if a second [Tab] event arrives when it's handling the current one (which may take a long time as it's saving the current line and starting the edition of the next one): it calls this._next which calls save_edition. The first call goes through, is_editing() passes, it starts saving and sets is_editing to falsy.

At this point the second call arrives[0], is_editing is false so it immediately returns with $.when() and _next(), which expected save information, blows up.

I see 2 ways:
* save_edition could fail (return $.Deferred.reject()) if not currently editing, the ensure_saved() wrapper (which originally contained the lock) would transform the failure into a success for its own callers (as they only care that any pending edition has been saved, if there was no pending edition they're ok), and thus the second _next call would just die (probably a good idea since the first one should have done all the stuff to do)
* or the TAB handler itself could avoid calling _next if we're already transitioning, that would probably require an additional flag on the object though...

[0] there's a wait lock around save_edition so it was made to wait until the first call finished, which is why it finds the record saved.

Should be fixed as of revision <email address hidden>