Replace MockLoggers in tests with fixtures.FakeLogger
Bug #125637 reported by
Brad Crittenden
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
Bug Description
Many places in our tests we locally define a MockLogger class. There exist two classes in Zope to support testing log output in tests.
Quote flacoste:
"There is zope.testing.
And there is also zope.testing.
Both of these work with the logging framework."
We should no longer be locally defining MockLogger classes and those currently in use should be replaced with the appropriate zope handler.
NOTE: MockLoggers have been removed and now we have FakeLoggers and subclasses in lp.services.
| Changed in launchpad: | |
| status: | New → Confirmed |
| description: | updated |
| Changed in launchpad: | |
| importance: | Undecided → Medium |
| summary: |
- Replace MockLoggers in tests with zope utilities + Replace MockLoggers in tests with zope handlers |
| description: | updated |
| Changed in launchpad: | |
| importance: | Medium → High |
Revision history for this message
| Robert Collins (lifeless) wrote Re: Replace MockLoggers in tests with zope handlers | #1 |
| summary: |
- Replace MockLoggers in tests with zope handlers + Replace MockLoggers in tests with fixtures.FakeLogger |
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | #2 |
To post a comment you must log in.
There is now a fixture in Fixtures (FakeLogger) which should supercede -all- of the ones we have.