/etc/init.d/icecc reports wrong starting actions

hi,

i can't reproduce the bug using 0.8.0-1 package.

/etc/default/icecc contains:

  1 # Defaults for icecc initscript
  2 # sourced by /etc/init.d/icecc
  3 START_ICECC="true"
  4 START_ICECC_SCHEDULER="false"

we read config file in /etc/init.d/icecc:
[...]
 15 CONFIGFILE=/etc/icecc/icecc.conf
 16 DEFAULTFILE=/etc/default/icecc
 17
 18 # Read configuration files
 19 [ -r $CONFIGFILE ] && . $CONFIGFILE
 20 [ -r $DEFAULTFILE ] && . $DEFAULTFILE
[...]

and on start case:
[...]
 78 start)
 79 if [ "$START_ICECC" = "true" ]; then
 80 log_daemon_msg "Starting distributed compiler daemon" "iceccd"
 81 start_icecc_daemon
 82 log_end_msg $?
 83 fi
 84
 85 if [ "$START_ICECC_SCHEDULER" = "true" ]; then
 86 log_daemon_msg "Starting distributed compiler scheduler" "icecc-scheduler"
 87 start_icecc_scheduler
 88 log_end_msg $?
 89 fi
 90 ;;
[...]

we show each message only if its own variable is set to true.

cheers,

Fathi

I'm sorry, its in the restart section:

       log_daemon_msg "Restarting distributed compiler daemon" "iceccd"
        stop_icecc_daemon
        sleep 1
        if [ "$START_ICECC" = "true" ]; then
            start_icecc_daemon
        fi
        log_end_msg $?

        log_daemon_msg "Restarting distributed compiler scheduler" "icecc-sched$
        stop_icecc_scheduler
        sleep 1
        if [ "$START_ICECC_SCHEDULER" = "true" ]; then
            start_icecc_scheduler
        fi
        log_end_msg $?

I confirm the bug. It is only present for the "stop" and "restart" actions.

root@X24:~# egrep -v '(^$|#)' /etc/default/icecc
START_ICECC="true"
START_ICECC_SCHEDULER="false"
root@X24:~# /etc/init.d/icecc restart
 * Restarting distributed compiler daemon iceccd [ ok ]
 * Restarting distributed compiler scheduler icecc-scheduler [ ok ]
root@X24:~# /etc/init.d/icecc stop
 * Stopping distributed compiler daemon iceccd [ ok ]
 * Stopping distributed compiler scheduler icecc_scheduler [ ok ]
root@X24:~# /etc/init.d/icecc start
 * Starting distributed compiler daemon iceccd [ ok ]

not present anymore in 0.8.0-2

$ sudo /etc/init.d/icecc restart
 * Restarting distributed compiler daemon iceccd Starting /usr/sbin/iceccd...
                                                                                                                      [ OK ]
 * Restarting distributed compiler scheduler icecc-scheduler [ OK ]

well, this is what it should look like

$ sudo /etc/init.d/icecc restart
 * Restarting distributed compiler daemon iceccd
Starting /usr/sbin/iceccd...
                                                                                                [ OK ]
 * Restarting distributed compiler scheduler icecc-scheduler [ OK ]

The restarting scheduler stanza does not say anything about a starting scheduler anymore and hence the bug is fixed.