Evergreen

DB patch supersede / deprecate func repairs; unit test

Bug #1262722 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 2.6.0-beta1

Bug Description

Evergreen 2.next (circa 2.5) -- could also be applied to 2.5, though, since it is a bug fix. (2.4 would require removal of pgtap test).

Repair the following errors within the DB patch version supersede / deprecate detection functions:

----------

ERROR: array value must start with "{" or dimension information

-- occurred when attempting to cast a string (config.upgrade_log.version) to text array.

----------

ERROR: set-valued function called in context that cannot accept a set
CONTEXT: SQL statement "SELECT ARRAY_AGG(evergreen.upgrade_list_applied_deprecates(my_db_patch))"
PL/pgSQL function "upgrade_deps_block_check" line 9 at RAISE

-------

Fixes and unit tests pushed to:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/db-patch-apply-func-repairs

Tags: pullrequest
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.6.0-alpha1 → 2.6.0-beta1
Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Bill! Hopefully we'll need this very soon!

Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Jeff Godin (jgodin) wrote :

One more bit of cleanup on this bug:

Bill Erickson discovered and fixed an issue where the pgTAP tests for this could fail due to lack of an explicit sort.

Repaired in working branch user/berick/pgtap-db-debs-check-sort-repair

I've tested, signed off, and pushed to master.

Thanks, Bill!

Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.