check_networks task result is non-consistent

Bug #1263097 reported by Aleksey Kasatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Vitaly Kramskikh

Bug Description

Result field of check_networks message have several parameters which must have 'dict' type to be interpretted correctly on UI side. So, UI cannot recognize messages correctly for a number of cases.

Sample message:
{"status": "error", "name": "check_networks", "cluster": 1, "result": [{"errors": ["cidr"], "id": [4, 5], "range_errors": ["192.0.0.0/2", "192.168.1.0/24"]}], "progress": 100, "message": "Address space intersection between networks:\nmanagement, storage.", "id": 5, "uuid": "12c20fd2-5561-44da-b4a8-2880d41897fa"}

"errors" and "id" fields must always have 'dict' type. "range_errors" fields is to be removed as it is not being used anywhere.

Changed in fuel:
milestone: none → 4.0
status: New → In Progress
assignee: nobody → Aleksey Kasatkin (alekseyk-ru)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63427

Changed in fuel:
assignee: Aleksey Kasatkin (alekseyk-ru) → Vitaly Kramskikh (vkramskikh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/63427
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=77af49d61cef23282ae111c4b77830ac49d36392
Submitter: Jenkins
Branch: master

commit 77af49d61cef23282ae111c4b77830ac49d36392
Author: Aleksey Kasatkin <email address hidden>
Date: Fri Dec 20 16:38:42 2013 +0200

    Fix check_networks task result

    1. "id" renamed to "ids".
    2. "ids" and "errors" are always lists.
    3. "range_errors" removed.
    4. "errors" values are subsets of NetworkGroup fields names.

    Closes-Bug: #1263097

    Change-Id: I30bb13c4613cf0b5a3f604ca350b2a594cbdf924

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.