Evergreen

SRU/Z39.50 results show deleted copies

Bug #1267252 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.5.2
2.4
Fix Released
Medium
Unassigned
Evergreen 2.4.6

Bug Description

In SRU & Z39.50 search results, copies which are deleted, but would otherwise be OPAC-visible, are included in holdings data. The cause of the bug is a simple Perl thinko. I have a fix which I'll push to the working repo momentarily.

Tags: pullrequest
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Fix is in the user/jeffdavis/lp1267252-sru-deleted-holdings branch of the working repo:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=3b83603

When a copy is deleted, the value of $cp->deleted is a string ('t'). The '==' operator doesn't do string comparison; instead, the test ($cp->deleted == 0) evaluates to 1, and the copy is treated as if it were NOT deleted. (I hope I've got that straight. Anyway the fix itself is simple enough.)

This bugfix should be backported.

tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Tested and works for me. Thanks Jeff!

Backported cleanly from master to rel_2_5, but with rel_2_4 there were conflicts due to whitespace vs. tab issues. Hand resolved the conflicts to make the change for rel_2_4 and it's in there too.

Changed in evergreen:
milestone: none → 2.5.2
status: New → Fix Committed
importance: Undecided → Low
importance: Low → Medium
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.