[PATCH] fix for appletouch driver generating unwanted CPU wakeups

Bug #129385 reported by Guillaume Pujol
12
Affects Status Importance Assigned to Milestone
linux-source-2.6.22 (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Hi,

As a MacBook Pro owner, I use the appletouch driver for the stock trackpad.
Until recently, this driver produced a lot (about 200) CPU wakeup/sec at any time (thanks to powertop for pointing that out). This behaviour has been fixed by a simple patch written by Matthew Garret and Soeren Sonnenburg in linux-2.6.23-rc1 ( see http://groups.google.fr/group/fa.linux.kernel/browse_thread/thread/d9d72416af5c6817/7b309dfbdbc5c3a0#7b309dfbdbc5c3a0 for the lkml discussion). Now appletouch create IRQ only when the trackpad is touched, allowing for a longer battery life.

It would be great if the kernel in Ubuntu Gutsy would include this patch.
I'll attach the patch below (taken directly by diffing the vanilla linux-2.6 git driver and the current ubuntu-gutsy git tree).
I read https://wiki.ubuntu.com/KernelPatches. I hope you will accept this patch
- It comes directly from upstream,
- It has been tested by kernel developpers, and has been in the mactel-linux svn repository for some weeks (used by most of the Apple MacBook (Pro) owners, including myself),
- No issues have been reported,
- It affects only 1 file (drivers/input/mouse/appletouch.c)
- It affects only the users of the appletouch driver (Apple MacBook (Pro) only),
- Waiting gutsy+1 in about 10 month to have this patch without having to manually managing the kernel is not an option.

Regards,

Revision history for this message
Guillaume Pujol (guill-p) wrote :
Revision history for this message
Tim Gardner (timg-tpi) wrote :

Gutsy commit 02e9f6b857029efbe99683f8d9038c3f527552dc

Changed in linux-source-2.6.22:
assignee: nobody → timg-tpi
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Henrik Nilsen Omma (henrik) wrote :

Thanks for the patch! Let's test the fix in tribe 6.

Revision history for this message
Henrik Nilsen Omma (henrik) wrote :

Moving milestone to beta.

btw, what's the best way for me to check whether this has been released in Gutsy?

Revision history for this message
Guillaume Pujol (guill-p) wrote :

The patch is in the Gutsy kernel since commit 02e9f6b857029efbe99683f8d9038c3f527552dc from 08/23 and has been released as linux-image-2.6.22-11 (If I remember correctly).

 http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-gutsy.git;a=commit;h=02e9f6b857029efbe99683f8d9038c3f527552dc

The patch works great for me, as powertop can confirm (the previous 200 wakeups/sec vanished).
And I didn't noticed any change in the trackpad behaviour.

Tim Gardner (timg-tpi)
Changed in linux-source-2.6.22:
assignee: timg-tpi → nobody
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.