OpenStack Heat

Docker container deletion should be intolerant to the fact if the container is present or not

Bug #1296758 reported by Chmouel Boudjnah
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Jeff Peeler
OpenStack Heat 2014.2 "juno"

Bug Description

When deleting container and the container failed to get started previously it is is impossible to properly delete it, most of other resources should be intolerant to that fact.

IRC log:

[15:38:20] <shardy> chmouel: can you expand on the requirement? For delete you should just be able to re-try the delete until you fix the error and it works
[15:38:55] <chmouel> shardy: well as an example I am trying out the docker container which failed to start for some reason
[15:39:11] <chmouel> shardy: if i want to try to delete it would just say cannot delete since it doesn't exist
[15:39:27] <chmouel> shardy: is it by design or it needs a fix in the docker client ?
[15:39:38] <shardy> chmouel: that's a bug, most resources tolerate NotFound exceptions and treat it as a successful delete

Chmouel Boudjnah (chmouel)
Changed in heat:
assignee: nobody → Chmouel Boudjnah (chmouel)
Jeff Peeler (jpeeler-z)
Changed in heat:
assignee: Chmouel Boudjnah (chmouel) → Jeff Peeler (jpeeler-z)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113371

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/117618

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/117618
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=69c662ac244e5275026abf6802a99b4fbf7ddf96
Submitter: Jenkins
Branch: master

commit 69c662ac244e5275026abf6802a99b4fbf7ddf96
Author: Jeff Peeler <email address hidden>
Date: Thu Aug 28 15:25:01 2014 -0400

    Rename docker directory to heat_docker

    This directory was renamed in 4e8231, which made importing docker
    (that is docker-py) difficult if not impossible in Python 2.x. So
    rename it to something other than 'docker' to avoid that problem.

    (setup.cfg has been modified with the new path)

    Change-Id: I3cbb7c5d4b53f70e1dc6102881f8e05852341a9a
    Related-bug: #1296758

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/113371
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ebc6cd9a26d4f77ee1510c5239e79e83758cf1d0
Submitter: Jenkins
Branch: master

commit ebc6cd9a26d4f77ee1510c5239e79e83758cf1d0
Author: Jeff Peeler <email address hidden>
Date: Wed Aug 6 16:15:43 2014 -0400

    Improve docker resource deletion

    handle_delete and check_delete_complete were not handling NotFound
    exceptions

    Change-Id: I6e8100ff37157f6a06837307cea31af66a3403af
    Closes-Bug: #1296758

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/119276

Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (stable/icehouse)

Change abandoned by Kieran Spear (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/119276

Thierry Carrez (ttx)
Changed in heat:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.