calendar icon wrong colour (compared to clock) for upcoming appointments
Bug #1307048 reported by
Alan Pope 🍺🐧🐱 🦄
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
indicator-datetime (Ubuntu) |
Invalid
|
Undecided
|
Charles Kerr | ||
unity8 (Ubuntu) |
Fix Released
|
Medium
|
Nick Dedekind |
Bug Description
Have appointments sync via calendar, note that pulling down indicator reveals icon which is black-on-grey whereas clock items appear white-on-grey.
Calendar icons are hard to see compared to clock items. See photo.
Related branches
lp:~nick-dedekind/unity8/lp1307048-appointment-colour
- Andrea Cimitan (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 102 lines (+30/-5)2 files modifiedplugins/Unity/Indicators/qml/MenuItemFactory.qml (+1/-1)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+29/-4)
Changed in unity8 (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in indicator-datetime (Ubuntu): | |
status: | Confirmed → Invalid |
Changed in unity8 (Ubuntu): | |
importance: | Undecided → Medium |
Changed in unity8 (Ubuntu): | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Hm, interesting. Alan, thanks for the photo.
The calendar with the correct color is being created in indicator- datetime- service' s src/menu.cpp by a call to g_themed_ icon_new_ with_default_ fallbacks( "calendar" ).
The black-on-grey calendar is coming from unity8's plugins/ Unity/Indicator s/qml/MenuItemF actory. qml's appointmentMenu definition, which uses "image: //theme/ calendar" .
If indicator- datetime- service needs to send the same icon over in both instances that's an easy enough fix; however, I wonder why image:/ /theme/ calendar is returning a black-on-grey item in the first place?