Cannot launch instances in French (using the modal)

Fix proposed to branch: master
Review: https://review.openstack.org/89534

Having reviewed the path it is not clear to me how the single quotes are obtained in:

  some_disabled_msg = '{{_("Some flavors not meeting minimum image requirements have been disabled.")|escapejs}}';
  all_disabled_msg = '{{_("No flavors meet minimum criteria for selected image.")|escapejs}}';

it seems it is being used |escapejs against a harcoded text which is not to be translated, and with no single quotes; but not sure if I am missing anything. Thanks.

Cristian,

_("hardcoded text") returns the translated hardcoded text, which in French would be "foo'bar". Filtering the final string with escapejs should prevent the issue with any language, even English if a quote is introduced at some point.

Got it. Thanks.

Not sure its worthwhile to argue the importance of this (since its getting active attention), but this seems like a pretty severe bug to me: a French user cannot launch instances at all.

Agreed, although to be completely fair there is an easy workaround: open in a new tab, so that you bypass the broken javascript.

Adrien - yes thanks for the workaround! That helps, but I'd still really hope to see this in our first fix release.

Reviewed: https://review.openstack.org/89534
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bc6f40b51d53682054cc4ba28b55b5045d6c8605
Submitter: Jenkins
Branch: master

commit bc6f40b51d53682054cc4ba28b55b5045d6c8605
Author: Adrien Cunin <email address hidden>
Date: Tue Apr 22 12:54:33 2014 +0200

    Use escapejs filter on JavaScript strings

    The escapejs filter will correctly escape single quotes from JavaScript
    strings which may otherwise trigger syntax errors. In this case, the
    issue was visible using the French translation.

    Also removed a trailing paranthesis coming out of nowhere.

    Change-Id: I25001815e17be5afa8eb28cc28c5423e3dcd973c
    Closes-Bug: #1311047

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/92006

Reviewed: https://review.openstack.org/92006
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=232b71286f3b1426412a3ffbed5d7065c2e24275
Submitter: Jenkins
Branch: stable/icehouse

commit 232b71286f3b1426412a3ffbed5d7065c2e24275
Author: Adrien Cunin <email address hidden>
Date: Tue Apr 22 12:54:33 2014 +0200

    Use escapejs filter on JavaScript strings

    The escapejs filter will correctly escape single quotes from JavaScript
    strings which may otherwise trigger syntax errors. In this case, the
    issue was visible using the French translation.

    Also removed a trailing paranthesis coming out of nowhere.

    Change-Id: I25001815e17be5afa8eb28cc28c5423e3dcd973c
    Closes-Bug: #1311047
    (cherry picked from commit bc6f40b51d53682054cc4ba28b55b5045d6c8605)