graphical diff-tool not usable when launched through "bzr gstatus"

Bug #131589 reported by Daniel Nyström
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Fix Released
Low
Vincent Ladeuil

Bug Description

The "gstatus" is a nice feature, but then I also like to see the differences in each file, as I give it a double-click.
The diff-tool opens up nicely, but then I can't do anything within it! It gets focus, but no scroll bars or buttons or even other files can't be clicked on. It seems like no "events" is reaching the "diff" application...
The "gstatus"-window also stays "always-on-top" of it, and the only way to close the windows is to press the "OK" button on the gstatus-window (or close it by the windows close button).

Tags: mysql
description: updated
Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 131589] graphical diff-tool not usable when launched through "bzr gstatus"

  status triaged
  importance low
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Changed in bzr-gtk:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
GuilhemBichot (guilhem-bichot) wrote :

Hello. I think "bzr gstatus" is good to see all uncommitted changes done, better than gcommit (which does not show unknown files, and locks the branch so you can't do gannotate).
So I humbly disagree that this should be low priority.
I hit the problem described in this bug report. Easy way to repeat:
BASE=~/tmp/gstatus_stall
rm -fr $BASE
mkdir -p $BASE
cd $BASE
bzr init this
cd this
touch foo
bzr add foo
bzr commit -m 'add'
echo mod >> foo
bzr gstatus
Then in the "bzr gstatus" window, double-click on "foo", it opens a diff window, and in that window try to click the "View" menu: like all other widgets of this window it does not respond. Even the "cross" to close the window does nothing.
The only way to close the window is to close the gstatus window.

Revision history for this message
Vincent Ladeuil (vila) wrote :

The root cause is that gstatus uses a gtk.Dialog instead of a gtk.Window.

There may be some other UI quirks (closing one window with Ctrl-W or Ctrl-Q will quit, closing all open windows, clicking the close button in diff windows close only the diff window) but switching to a window addresses the bug so I will not address them in that fix.

Changed in bzr-gtk:
assignee: nobody → vila
status: Triaged → In Progress
Vincent Ladeuil (vila)
Changed in bzr-gtk:
milestone: none → 0.96.0
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.