DownloadManager class not using web::Client
Bug #1317292 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Alejandro J. Cura | ||
| unity-scope-click (Ubuntu) |
Fix Released
|
Medium
|
dobey | ||
Bug Description
Currently, the DownloadManager class is performing it's own authentication and HTTP requests, and not using click::web::Client to perform this work.
It needs to use the web::Client API so that all code talking to our web services is going through the same tested code paths.
Related branches
lp:~dobey/unity-scope-click/webclient-dm
- Charles Kerr (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 2312 lines (+481/-1177)20 files modifiedCMakeLists.txt (+1/-1)
libclickscope/click/download-manager.cpp (+97/-323)
libclickscope/click/download-manager.h (+20/-50)
libclickscope/click/preview.cpp (+93/-83)
libclickscope/click/preview.h (+11/-11)
libclickscope/click/webclient.cpp (+16/-3)
libclickscope/click/webclient.h (+1/-0)
libclickscope/tests/mock_ubuntu_download_manager.h (+14/-1)
libclickscope/tests/mock_webclient.h (+1/-0)
libclickscope/tests/test_download_manager.cpp (+174/-439)
libclickscope/tests/test_preview.cpp (+38/-60)
libclickscope/tests/test_webclient.cpp (+4/-4)
scope/clickapps/apps-scope.cpp (+5/-4)
scope/clickapps/apps-scope.h (+2/-0)
scope/clickstore/store-scope.cpp (+2/-1)
scope/clickstore/store-scope.h (+2/-0)
scope/tests/CMakeLists.txt (+0/-1)
scope/tests/download_manager_tool/CMakeLists.txt (+0/-14)
scope/tests/download_manager_tool/download_manager_tool.cpp (+0/-123)
scope/tests/download_manager_tool/download_manager_tool.h (+0/-59)
| Changed in unity-scope-click (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in unity-scope-click (Ubuntu): | |
| status: | New → Triaged |
| Changed in unity-scope-click (Ubuntu): | |
| assignee: | nobody → Rodney Dawes (dobey) |
| status: | Triaged → In Progress |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| importance: | Undecided → Medium |
| milestone: | none → ww08-2016 |
| status: | New → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scope-click (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity-scope-click - 0.1.1+16.
---------------
unity-scope-click (0.1.1+
[ Antti Kaijanmäki ]
* libclickscope/
QString:
[ CI Train Bot ]
* Resync trunk.
[ Rodney Dawes ]
* Add an "ignored-apps" gsettings key for a list of apps to ignore in
results. Generate a gsettings schema during build for the app scope
tests. Use the temporary schema and memory backend for app scope
tests. (LP: #1536665)
* Refactor download manager class to use web::Client for network
usage. Update all usage of click::
API. Add a method to the web::Client to invalidate credentials.
Remove integration-harness tests from coverage rule. (LP: #1432506,
#1317292)
* Use the online-accounts integration for payments button. Refresh the
store results on purchase cancellation. (LP: #1513093)
-- Rodney Dawes <email address hidden> Mon, 07 Mar 2016 14:10:31 +0000