mediascanner2

Cannot filter models to only AudioMedia

Bug #1319168 reported by Andrew Hayzen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Music App
Fix Released
High
Unassigned
mediascanner2
Fix Released
Undecided
James Henstridge

Bug Description

The first entry in the ArtistsModel is empty, as can be seen in the example application [0]. This then causes issues for the music-app as when selecting the artist it shows all the albums/songs in the library.

I expected that this first entry should not even exist, unless we are using it incorrectly?

0 - https://code.launchpad.net/~andrew-hayzen/+junk/example-first-artist-empty

Related branches

lp:~ahayzen/+junk/example-first-artist-empty
lp:~jamesh/mediascanner2/media-filter
PS Jenkins bot (community): Approve (continuous-integration)
Mediascanner Team: Pending requested
Diff: 2163 lines (+1313/-184)
33 files modified
src/mediascanner/CMakeLists.txt (+1/-0)
src/mediascanner/Filter.cc (+154/-0)
src/mediascanner/Filter.hh (+66/-0)
src/mediascanner/MediaStore.cc (+93/-34)
src/mediascanner/MediaStore.hh (+6/-3)
src/ms-dbus/dbus-codec.cc (+45/-0)
src/ms-dbus/dbus-codec.hh (+24/-0)
src/ms-dbus/dbus-interface.hh (+26/-0)
src/ms-dbus/service-skeleton.cc (+64/-14)
src/ms-dbus/service-stub.cc (+30/-15)
src/ms-dbus/service-stub.hh (+6/-3)
src/qml/Ubuntu/MediaScanner/AlbumModelBase.cc (+1/-0)
src/qml/Ubuntu/MediaScanner/AlbumModelBase.hh (+3/-1)
src/qml/Ubuntu/MediaScanner/AlbumsModel.cc (+61/-22)
src/qml/Ubuntu/MediaScanner/AlbumsModel.hh (+11/-7)
src/qml/Ubuntu/MediaScanner/ArtistsModel.cc (+27/-2)
src/qml/Ubuntu/MediaScanner/ArtistsModel.hh (+8/-1)
src/qml/Ubuntu/MediaScanner/CMakeLists.txt (+1/-0)
src/qml/Ubuntu/MediaScanner/GenresModel.cc (+86/-0)
src/qml/Ubuntu/MediaScanner/GenresModel.hh (+71/-0)
src/qml/Ubuntu/MediaScanner/MediaFileModelBase.cc (+1/-0)
src/qml/Ubuntu/MediaScanner/MediaFileModelBase.hh (+3/-1)
src/qml/Ubuntu/MediaScanner/SongsModel.cc (+82/-34)
src/qml/Ubuntu/MediaScanner/SongsModel.hh (+14/-10)
src/qml/Ubuntu/MediaScanner/plugin.cc (+2/-0)
src/qml/Ubuntu/MediaScanner/plugin.qmltypes (+29/-5)
src/qml/Ubuntu/MediaScanner/qmldir (+1/-0)
test/qml/tst_albumsmodel.qml (+91/-0)
test/qml/tst_artistsmodel.qml (+68/-0)
test/qml/tst_genresmodel.qml (+44/-0)
test/qml/tst_songsmodel.qml (+104/-0)
test/test_dbus.cc (+39/-12)
test/test_mediastore.cc (+51/-20)
lp:ubuntu/utopic-proposed/mediascanner2
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

This is a screenshot [1] of [0] running on the Nexus 4 r26.

1 - https://drive.google.com/file/d/0B3XynHVKfrvMdXRDeVc5X1UtMWc/edit

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Discovered this is because I have a video in my library, however how to we filter the models to only show audio. I see a AudioMedia MediaType [2], which I assume would resolve this issue, but am unsure how to use it?

2 - http://bazaar.launchpad.net/~mediascanner-team/mediascanner2/trunk/view/head:/src/qml/Ubuntu/MediaScanner/plugin.qmltypes#L120

Andrew Hayzen (ahayzen)
summary: - First entry in AristsModel is empty
+ Cannot filter models to only AudioMedia
Andrew Hayzen (ahayzen)
Changed in music-app:
status: New → Triaged
importance: Undecided → High
Revision history for this message
James Henstridge (jamesh) wrote :

In the attached branch, the genres, artists, albums and songs models are limited to AudioMedia.

Revision history for this message
James Henstridge (jamesh) wrote :

Fixed in 0.101+14.10.20140530-0ubuntu1

The Genres, Artists, Albums and Songs models all limit themselves to AudioMedia now.

Changed in mediascanner2:
assignee: nobody → James Henstridge (jamesh)
status: New → Fix Released
Victor Thompson (vthompson)
Changed in music-app:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.