Mir

[regression] [input] Scroll events are now always zero: event.motion.pointer_coordinates[0].vscroll

Bug #1321077 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Andreas Pokorny
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[regression] [input] Scroll events are now always zero: event.motion.pointer_coordinates[0].vscroll

Merging changes that landed on development-branch last night I notice vscroll is now always zero when action==mir_motion_action_scroll. Previously vscroll had values +1 or -1. Now it's always zero. This stops all logic that relies on the mouse wheel from working.

Test case:
  1. Start: mir_demo_server_shell
  2. Start a client
  3. Alt+mousewheel up/down

Expected: Window opacity changes
Observed: No change to window opacity

Related branches

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm not quite sure how, but it looks like the regression probably came from:

------------------------------------------------------------
revno: 1639 [merge]
author: Andreas Pokorny <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Mon 2014-05-19 22:10:04 +0000
message:
  Removing InputDispatcherConfiguration and the by-pass of the InputTranslator using a dynamic cast that was only necessary until lp~andreas-pokorny:extended-input-dispatcher lands

  The contents of the former InputDispatcherConfiguration have been moved to DefaultServerConfiguration. En passent the nested input relay was dropped too. The mir::input::InputDispatcher interface is now used directly. Note: Event filtering still works like before.

  Approved by PS Jenkins bot, Alexandros Frantzis, Alan Griffiths, Chris Halse Rogers.
------------------------------------------------------------

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

AMOTION_EVENT_AXIS_HSCROLL/VSCROLL is not assigned in AndroidInputDispatcher.. fixing

Changed in mir:
assignee: nobody → Andreas Pokorny (andreas-pokorny)
Changed in mir:
status: Triaged → In Progress
description: updated
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (7.2 KiB)

This bug was fixed in the package mir - 0.2.0+14.10.20140605-0ubuntu1

---------------
mir (0.2.0+14.10.20140605-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.2.0 (https://launchpad.net/mir/+milestone/0.2.0)
    - mirclient ABI unchanged, still at 7. Clients do not need rebuilding.
    - mirserver ABI bumped to 20. Shells need rebuilding.
      . Cursor::set_image() parameters changed.
      . Display::the_cursor() renamed to Display::create_hardware_cursor()
      . Platform::create_display() requires a new parameter; gl_program_factory
      . Renderable::buffer() no longer accepts any parameter at all. Multi-
        monitor frame sync is guaranteed in other ways now.
      . Scene::generate_renderable_list() renamed to renderable_list_for(id)
        where id is an opaque compositor ID of your choosing.
      . Scene::set_change_callback() replaced by the more generic:
        add_observer() and remove_observer() functions.
      . Added default implementation for SceneObserver.
      . SessionCreator renamed to ConnectionCreator.
      . ConnectedSessions renamed to Connections.
      . ProtobufSessionCreator renamed to ProtobufConnectionCreator.
      . SessionAuthorizer: pid_t parameters replaced by SessionCredentials.
      . Massive architectural changes to Input-everything.
      . Surface no longer implements Renderable, but emits one via
        compositor_snapshot().
      . Pass the full renderable list to Renderer::render().
      . Graceful handling of exceptions thrown from server threads.
      . Clarify size position interfaces in the Surface classes.
      . Plumbing for trusted sessions.
      . Allow posting and managing custom main-loop actions.
      . Timer extension.
      . Identify client process when client connects to Mir not when socket
        connects.
      . Use the ServerActionQueue for display config.
      . Recomposition signal moved to the MultiThreadedCompositor.
      . Make timer service replaceable.
      . Clarify assumptions about how many buffers a client can fill without
        blocking.
      . Introduce EmergencyCleanup interface.
    - Demo shell enhancements:
      . You can now change graphics modes on the fly using Ctrl+Alt+(-/=).
        To reset to the preferred mode use Ctrl+Alt+0.
      . The above mode changing as well as existing screen rotation keys
        (Ctrl+Alt+arrows) are now per-display; only applied to the monitor
        the mouse pointer is on.
      . New shell controls documented.
    - A new testing category, performance test, was introduced. It currently
      runs glmark2-es2 and compares the result to a minimum threshold.
    - MIR_VERSION_MINOR is tied to MIRSERVER_ABI in the sense that a change
      in the former now requires dependent projects that a rebuild is
      necessary.
    - SwitchingBundle was replaced by BufferQueue.
    - Expand credentials to include uid/gid for session authorizer.
    - Bypass control is now Mesa-specific and tied to the command line options.
      So the environment variable MIR_BYPASS has changed to MIR_SERVER_BYPASS.
    - Ongoing architectural changes in the compositor/renderer logic to
   ...

Read more...

Changed in mir (Ubuntu):
status: New → Fix Released
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.