[PATCH] Let DE decide which file manager to use instead of custom mechanism

Bug #1322368 reported by Jethro Beekman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Onboard
Fix Released
Low
Unassigned
onboard (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Currently, the file manager used to open the user layout directory is determined as follows: If Nautilus is installed, use Nautilus. Otherwise, if Thunar is installed, use Thunar.

This has two problems:
1) The user might have Nautilus/Thunar installed, even though this is not the default. Onboard would still launch the non-default.
2) The user might not have Nautilus/Thunar installed, in which case Onboard fails silently.

This patch uses xdg-open instead to let the Desktop Environment decide which file manager to use.

Tags: patch
Revision history for this message
Jethro Beekman (jethrogb) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Let DE decide which file manager to use instead of custom mechanism" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
marmuta (marmuta)
Changed in onboard:
status: New → Confirmed
importance: Undecided → Low
Changed in onboard (Ubuntu):
status: New → Confirmed
Revision history for this message
marmuta (marmuta) wrote :

Thank you, applied to trunk. I just switched it from using os.system to Popen and added a new dependency to xdg-utils.
https://bazaar.launchpad.net/~onboard/onboard/trunk/revision/1807

Changed in onboard:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (8.1 KiB)

This bug was fixed in the package onboard - 1.1.0-0ubuntu1

---------------
onboard (1.1.0-0ubuntu1) vivid; urgency=low

  * Request for sponsorship for new upstream release (LP: #1415041)
  * debian/control:
    - Raise Standards-Version to 3.9.6
    - Add xdg-utils to Recommends
  * debian/copyright:
    - Edit emails to add small protection against email harvesting
    - Update years information
  * debian/onboard.install:
    - Add the usr/share/onboard/settings_auto_show_dialog.ui file
  * debian/patches:
    - Remove patch to add support for MATE (now upstream)
    - Remove patch to fix the auto-start issue (now upstream)
    - Update add_defaults_for_ubuntu.patch with values for this release
  * debian/rules:
    - Remove shebang rewrite from override_dh_python3
    - Add no-guessing-deps to override_dh_python3
  * Word suggestions:
    - Add possibility to learn word sequences, but no new words
    - Add removal of words from current user language model on long press
    - Add removal of a word in current context only
    - Add tool to extract letter frequencies from a given language model
    - Use slash as word separator in the path component of URLs
    - Improve word suggestions after a wrap to a second line in gnome-terminal
    - Better handle interaction with the awesome bar's URL completion of firefox
    - Fix synchronisation between libreoffice writer and text document
    - Fix insertion of word separators consisting of more than one character
    - Delete selected text before inserting suggestions into Gtk-3 widgets
    - Fix memory leak in predict calls
    - Improve robustness of language model loading by handling word counts <= 0
    - Have the checkmodels tool check for valid n-gram frequency fields
    - Fix and improve broken doctest for _get_word_to_spell_check()
    - Remove "th" from the English system language models
    - Increase the number of words in the German system language models
    - Fix traceback when migrating user language model with LANG=C
    - Always use "Other Languages" as name for submenu of languages menu
    - Move second separator in language menu to correct position
  * Auto-show and auto-hide:
    - Add hiding of Onboard keyboard on physical key-press for XInput
    - Add setting for the time to stay hidden after physical key-press
    - Add possibility to turn off repositioning on auto-show (LP #1402212)
    - Centralize auto-show code to make it available for future views
    - Correctly register at-spi listeners on startup
    - Correctly disconnect events on exit
    - Fix auto-show on cursor movement in single-line text entries
  * XEmbedding in unity-greeter and gnome-screensaver:
    - Enable hide button in unity-greeter; needs restart until greeter assists
    - Add a toggle to system defaults to enable the background image
    - Read filename of background in greeter's shema in unity-greeter
    - Ignore xembed-unity-greeter-offset-x on small screens
    - Increase xembed aspect change range (LP: #1297695)
    - Add the color of the background bar to system defaults
    - Fix loading of desktop backgrounds with non-ascii filenames
    - Fix black bars problem
    - Fix background ...

Read more...

Changed in onboard (Ubuntu):
status: Confirmed → Fix Released
Changed in onboard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.