Security group "updated" timestamp is not being updated when new rule appers.

Bug #1325967 reported by Denis M.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Denis M.

Bug Description

Security group "updated" timestamp is not being updated when new rule appears. It still the same as "created".

Steps to reproduce:
1. Create instance (. ~/devstack/openrc; trove create mysql 2 --size 2).
2. List security groups (. ~/devstack/openrc; trove secgroup-list).
3. Grep security group id that is assigned to instance (from Step 1).
4. Call show for secruity group (from Step 3).
5. Compare "created" and "updated" timestamps (should be equal).
6. Create new rule (
. ~/devstack/openrc; trove secgroup-rule-add <secgroup-id> 1.2.3.4/24).
7. Do Step 4 and 5.

You will found out that "created" "updated" are the same. But "updated" should be changed.

Same thing happens with delete call for rule, updated timestamp doesn't change.

Denis M. (dmakogon)
Changed in trove:
assignee: nobody → Denis M. (dmakogon)
status: New → In Progress
description: updated
Denis M. (dmakogon)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97510

Changed in trove:
importance: Undecided → Low
milestone: none → juno-1
Denis M. (dmakogon)
description: updated
Changed in trove:
milestone: juno-1 → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/97510
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=e7f4143eada015167d9c2dd49ba9221f997ad7b1
Submitter: Jenkins
Branch: master

commit e7f4143eada015167d9c2dd49ba9221f997ad7b1
Author: Denis Makogon <email address hidden>
Date: Wed Jun 11 14:14:59 2014 +0300

    Fix updated timestamp for SecurityGroup model

    Reasons:
     - Security group "updated" timestamp is not being
       updated when new rule appears. It still the same as "created".
     - Security group "updated" timestamp is not being
       updated when rule is being deleted.

    Changes:
     - adding `save` step after security group rules creation.
     - adding `save` step after security group rules deletion.
     - adding integration test that validates that timestamp
       was changed after creation and deletion.

    Change-Id: I92ee7207366511cd4bc5dff07337031faeed0182
    Closes-Bug: #1325967

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.