get_oauth_params() missing 1 required positional argument: 'request'

Bug #1327430 reported by Steve Martinelli
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
High
Steve Martinelli

Bug Description

The tests for keystoneclient are currently failing because the newest version of oauthlib (0.6.2) changed a positional argument for get_oauth_params()

2014-06-06 18:27:10.698 | Traceback (most recent call last):
2014-06-06 18:27:10.698 | File "/home/jenkins/workspace/gate-python-keystoneclient-python33/.tox/py33/lib/python3.3/site-packages/httpretty/core.py", line 1013, in wrapper
2014-06-06 18:27:10.698 | return test(*args, **kw)
2014-06-06 18:27:10.698 | File "./keystoneclient/tests/v3/test_oauth1.py", line 188, in test_create_request_token
2014-06-06 18:27:10.699 | oauth_client)
2014-06-06 18:27:10.699 | File "./keystoneclient/tests/v3/test_oauth1.py", line 105, in _validate_oauth_headers
2014-06-06 18:27:10.699 | header_params = oauth_client.get_oauth_params()
2014-06-06 18:27:10.699 | TypeError: get_oauth_params() missing 1 required positional argument: 'request'
2014-06-06 18:27:10.699 | ======================================================================
2014-06-06 18:27:10.699 | FAIL: process-returncode
2014-06-06 18:27:10.699 | tags: worker-7
2014-06-06 18:27:10.699 | ----------------------------------------------------------------------
2014-06-06 18:27:10.699 | Binary content:
2014-06-06 18:27:10.699 | traceback (test/plain; charset="utf8")
2014-06-06 18:27:10.699 | ======================================================================
2014-06-06 18:27:10.699 | FAIL: keystoneclient.tests.v3.test_oauth1.AccessTokenTests.test_create_access_token_expires_at
2014-06-06 18:27:10.700 | tags: worker-0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98534

Changed in python-keystoneclient:
assignee: nobody → Steve Martinelli (stevemar)
status: New → In Progress
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/98534
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=6663e1360d6fb5a3fe90d0bcfe5c128dac16ffd2
Submitter: Jenkins
Branch: master

commit 6663e1360d6fb5a3fe90d0bcfe5c128dac16ffd2
Author: Steve Martinelli <email address hidden>
Date: Fri Jun 6 17:41:26 2014 -0400

    Make get_oauth_params conditional for specific oauthlib versions

    With recent change to oauthlib 0.6.2, the get_oauth_params method
    now takes an extra argument. This patch will change the behaviour
    of test method _validate_oauth_headers, which will call
    get_oauth_params with or without the extra argument, depending
    on the version of oauthlib detected.

    Change-Id: Id82c28993fa735b8c5b1a4d64ed2f55cc2eddbba
    Closes-Bug: #1327430

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.10.0
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.