Awn

Make awn-manager find applets from directories in $(prefix)

Bug #133353 reported by elshaman
4
Affects Status Importance Assigned to Milestone
Awn
Fix Released
Wishlist
Unassigned

Bug Description

Hello,

awn-manager currently ignores where AWN has been installed and always tries to find applets into /usr/* subdirectories.

I am sending a patch that makes users able to install AWN into their home and still have awn-manager finding awn applets.

Bonus question: why 'intltool-merge.in' is shipped?

Laurent Aguerreche.

Revision history for this message
elshaman (elshaman) wrote :
Revision history for this message
elshaman (elshaman) wrote :

Terms like @PREFIX@ are still not processed correctly. See file taskman.desktop.in.in for instance :

[Desktop Entry]
Type=C
Encoding=UTF-8
Name=Launcher/Taskmanager
Comment=The main Awn Launcher/TaskManager applet
Exec=None
Icon=@PKGDATADIR@/avant-window-navigator.svg

Term @PKGDATADIR@ has not been replaced.

So AWN is not properly installed when a user installs it in a directory defined by prefix and different than /usr.

Again, is it possible to fix that?
I am very astonished to thing that AWN developers have to always install AWN in /usr as root to just test it...

Revision history for this message
elshaman (elshaman) wrote :

" pkg-config awn --cflags " returns a wrong path for headers, "libawn" at the end should be removed.

Currently: -I/home/foo/AWN/Build/AWN/include/libawn
Expected: -I/home/foo/AWN/Build/AWN/include
according to source codes found with AWN applets.

So, in awn.pc:

Name: libawn
Description: Avant-Window-Navigator applets/plugin library
Version: 0.1.1
Libs: -L${libdir} -lawn
Cflags: -I${includedir}
Requires: glib-2.0 gobject-2.0 gtk+-2.0 gdk-2.0 libgnome-2.0 gnome-vfs-2.0 gconf-2.0

Revision history for this message
Mark Lee (malept) wrote :

FYI, this behavior is fixed in the desktop-agnostic branch.

Revision history for this message
Mark Lee (malept) wrote :

This patch is a backport of the same fix in the desktop-agnostic branch for both 0.2-stable-testing and trunk. It correctly substitutes @PREFIX@ for the install prefix in awn-manager/awnDefs.in.py, and searches for applets in the installed prefix.

Revision history for this message
Mark Lee (malept) wrote :

This patch cleans up awn.pc by removing a line that seems to have remained from the clutter pkgconfig file that I assume awn's pkgconfig file was originally copied from, and changes the Cflags line per https://bugs.launchpad.net/awn/+bug/133353/comments/3 . Created against 0.2-stable-testing, but it should apply against trunk. This change was originally in desktop-agnostic as of revision 23.

Revision history for this message
Mark Lee (malept) wrote :

A couple of people have found a bug in my prefix patch - if the install prefix is /usr or /usr/local, then system-installed applets get shown twice. The following patch fixes that.

Michal Hruby (mhr3)
Changed in awn:
importance: Undecided → Wishlist
status: New → Fix Committed
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

0.2.1 released

Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.