Mir

mir client API is missing getters for some surface attributes

Bug #1336553 reported by Daniel d'Andrada
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Robert Carr
Mir 0.6.0
mir (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

mir_surface_attrib_type -> mir_surface_get_type()
mir_surface_attrib_state -> mir_surface_get_state()
mir_surface_attrib_swapinterval -> mir_surface_get_swapinterval()
mir_surface_attrib_focus -> MISSING!
mir_surface_attrib_dpi -> mir_surface_get_dpi()
mir_surface_attrib_visibility -> MISSING!

Tags: clientapi

Related branches

lp:~mir-team/mir/improve-attribute-protocol-and-normalize-getters
Gerry Boland (community): Approve
Alexandros Frantzis (community): Approve
Daniel van Vugt: Abstain
Chris Halse Rogers: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 933 lines (+383/-171)
16 files modified
include/client/mir_toolkit/mir_surface.h (+14/-0)
include/server/mir/frontend/surface.h (+1/-0)
include/shared/mir_toolkit/common.h (+4/-0)
include/test/mir_test_doubles/mock_frontend_surface.h (+1/-0)
include/test/mir_test_doubles/stub_scene_surface.h (+1/-0)
src/client/mir_surface.cpp (+6/-3)
src/client/mir_surface.h (+3/-0)
src/client/mir_surface_api.cpp (+49/-10)
src/server/frontend/session_mediator.cpp (+9/-0)
src/server/scene/basic_surface.cpp (+125/-62)
src/server/scene/basic_surface.h (+9/-8)
src/shared/protobuf/mir_protobuf.proto (+2/-0)
tests/acceptance-tests/test_client_surface_visibility.cpp (+4/-1)
tests/unit-tests/client/test_client_mir_surface.cpp (+38/-26)
tests/unit-tests/scene/test_basic_surface.cpp (+117/-15)
tests/unit-tests/scene/test_surface_impl.cpp (+0/-46)
lp:ubuntu/utopic-proposed/mir
Robert Carr (robertcarr)
Changed in mir:
assignee: nobody → Robert Carr (robertcarr)
status: New → In Progress
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I recall focus being an attribute was kind of a convenient hack to fit the existing code. Really I still don't think it should be an attribute and thus should not have a getter. Surely it's more useful to ask Mir which surface has focus rather than probe each one. You can do more with such a function.

As for visibility, AFAIK we have no client API to explicitly set visibility so it shouldn't be gettable yet either.

Changed in mir:
status: In Progress → Opinion
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> As for visibility, AFAIK we have no client API to explicitly set visibility so it shouldn't be gettable yet either.

So your can't have read-only attributes?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sorry, not awake. You're right that some attributes will be read only. What I should have said is that visibility is not something that would ever change. At least not in the traditional windowing sense we don't use the visibility flag.

What I didn't realize is that while I vacationed we implemented occlusion notifications, and called it "visibility". That's a misnomer that confused me and we should probably fix. So yes, mir_surface_attrib_visibility would need a getter. Hopefully under a different name.

Changed in mir:
importance: Undecided → Low
status: Opinion → Triaged
tags: added: clientapi
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.5.0
status: Triaged → In Progress
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.5.0 → 0.6.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

mir (0.6.0+14.10.20140811-0ubuntu1) utopic; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → Low
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.