valid_name and valid_branch_name are not consistent
Bug #134090 reported by
Michael Hudson-Doyle
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Michael Hudson-Doyle | ||
Bug Description
In trusted.sql we find this:
COMMENT ON FUNCTION valid_branch_
IS 'validate a branch name.
As per valid_name, except we allow uppercase and @';
This isn't really true, though, as valid_name allows one character names, but valid_branch_name does not (see https:/
<ddaa> We can deal with this in various ways
<ddaa> 1. loose valid_branch_name
<ddaa> 2. special case naming of import branches for single-char series
<ddaa> 3. tighten valid_name
<ddaa> I favor 1.
<mwhudson> me too
| description: | updated |
Revision history for this message
| David Allouche (ddaa) wrote | #1 |
| Changed in launchpad: | |
| importance: | Undecided → Critical |
| status: | New → Confirmed |
Revision history for this message
| David Allouche (ddaa) wrote | #2 |
| Changed in launchpad: | |
| importance: | Critical → High |
Revision history for this message
| David Allouche (ddaa) wrote | #3 |
| Changed in launchpad-bazaar: | |
| assignee: | nobody → mwhudson |
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | #4 |
| Changed in launchpad-bazaar: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | #5 |
| Changed in launchpad-bazaar: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | #6 |
| Changed in launchpad-bazaar: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Confirming, importance critical as it allows user to set up series for which we cannot deliver a code import without changing the name of the series.