When unconstrained, udm sometimes downloads files to wrong location

Now, I'm absolutely positive I never give a local file path with 'mission-control' in it, but look at this:

@limelight[~:630]% ls -lR ~/.local/share/ubuntu-download-manager/usr/
/home/barry/.local/share/ubuntu-download-manager/usr/:
total 8
drwxr-xr-x 3 barry barry 4096 Jul 11 18:09 bin/
drwxr-xr-x 3 barry barry 4096 Jun 9 13:00 lib/

/home/barry/.local/share/ubuntu-download-manager/usr/bin:
total 4
drwxr-xr-x 3 barry barry 4096 Jul 11 18:09 mediascanner-service-2.0/

/home/barry/.local/share/ubuntu-download-manager/usr/bin/mediascanner-service-2.0:
total 4
drwxr-xr-x 2 barry barry 4096 Jul 11 18:09 Downloads/

/home/barry/.local/share/ubuntu-download-manager/usr/bin/mediascanner-service-2.0/Downloads:
total 24
-rw-r--r-- 1 barry barry 1388 Jul 11 18:09 blacklist.tar.xz
-rw-r--r-- 1 barry barry 819 Jul 11 18:09 blacklist.tar.xz.asc

/home/barry/.local/share/ubuntu-download-manager/usr/lib:
total 4
drwxr-xr-x 4 barry barry 4096 Jul 11 09:22 telepathy/

/home/barry/.local/share/ubuntu-download-manager/usr/lib/telepathy:
total 8
drwxr-xr-x 3 barry barry 4096 Jun 9 13:00 mission-control-5/
drwxr-xr-x 3 barry barry 4096 Jul 11 09:22 telepathy-ofono/

/home/barry/.local/share/ubuntu-download-manager/usr/lib/telepathy/mission-control-5:
total 12
drwxr-xr-x 2 barry barry 12288 Jul 14 14:38 Downloads/

/home/barry/.local/share/ubuntu-download-manager/usr/lib/telepathy/mission-control-5/Downloads:
total 816
-rw-r--r-- 1 barry barry 1388 Jul 11 14:39 blacklist (10).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 11 14:39 blacklist (10).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 11 15:20 blacklist (11).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 11 15:20 blacklist (11).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 11 18:29 blacklist (12).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 11 18:29 blacklist (12).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 10:05 blacklist (13).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 10:05 blacklist (13).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 10:26 blacklist (14).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 10:26 blacklist (14).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 10:42 blacklist (15).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 10:42 blacklist (15).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 10:42 blacklist (16).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 10:42 blacklist (16).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 10:58 blacklist (17).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 10:58 blacklist (17).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 11:28 blacklist (18).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 11:28 blacklist (18).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 11:48 blacklist (19).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 11:48 blacklist (19).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jun 9 14:44 blacklist (1).tar.xz
-rw-r--r-- 1 barry barry 819 Jun 9 14:44 blacklist (1).tar.xz.asc
-rw-r--r-- 1 barry barry 1384 Jul 14 12:08 blacklist (20).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 12:08 blacklist (20).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jul 14 14:38 blacklist (21).tar.xz
-rw-r--r-- 1 barry barry 819 Jul 14 14:38 blacklist (21).tar.xz.asc
-rw-r--r-- 1 barry barry 1388 Jun 1...

I wonder if it's some messed up calculation as to whether we're unconstrained or not?

Running the full test suite on two different machines (laptop and desktop), I see different test failures with the same symptoms. The local paths are messed up in the described way, but there's no overlap between the two machine's test failures. At least on the desktop it's always the same test that fails.

One more data point for the day. Indeed, while the set of tests that are failing with this symptom differs between my desktop and laptop, they are completely reproducible on each machine. The same one test fails on desktop every time, while it's the same three tests that always fail on laptop.

It always seems to be /usr/lib/telepathy/mission-control-5 even on different systems. Why?!

I deleted ~/.local/share/ubuntu-download-manager and re-ran the tests, and so far haven't gotten any failures. However, now I see that there are more directories under ~/.local/share/ubuntu-download-manager such as usr/lib/telepathy/{mission-control-5,telepathy-ofono}/

Maybe there's a leakage in paths from one download (or group download) to another. E.g. after telepathy runs it pollutes the download paths for other clients? Just more conjecture.

Hi Manuel - have you had time to look into this? It's still causing intermittent test failures in system-image.

My assertion is getting triggered again.

I've beefed up the output when the assertion fails. here's what I see:

AssertionError: dbus.Boolean(False) is not true : Missing destination files: ['/tmp/tmp89brss02/ubuntu/cache/keyring.tar.xz', '/tmp/tmp89brss02/ubuntu/cache/keyring.tar.xz.asc']
local_paths: [dbus.String('/home/barry/.local/share/ubuntu-download-manager//usr/lib/telepathy/telepathy-ofono/Downloads/blacklist (20).tar.xz'), dbus.String('/home/barry/.local/share/ubuntu-download-manager//usr/lib/telepathy/telepathy-ofono/Downloads/blacklist (20).tar.xz.asc')]

Is there any explanation for why those bogus local_paths are being returned in the `finished` signal? Note that the missing destination file paths are what's being given to udm.

Even the fact that /usr/lib/telepathy/telepathy-ofono even appears is crazy! That's a binary, not a directory so can't possibly have Downloads/ in it.

Not sure why, can't attach my branch to the bug; it's at lp:~lool/ubuntu-download-manager/dbus-proxy-requires-dbus

Testsuite now passes on above branch; would like to get a build of it.

please fix after RTM via OTA

On Oct 28, 2014, at 03:49 PM, Olli Ries wrote:

>please fix after RTM via OTA

Shouldn't this be fixed for RTM?

Any updates on when we can land this? Can I propose it for vivid?

On Nov 17, 2014, at 10:36 PM, Manuel de la Peña wrote:

>Any updates on when we can land this? Can I propose it for vivid?

Are there any blocks on vivid landings?

there are no blocks on vivid landings

this could have landed any time this year