/etc/init.d/tor doesn't use log_daemon_msg/log_end_msg

Bug #134208 reported by Ralf Hildebrandt
8
Affects Status Importance Assigned to Milestone
tor (Ubuntu)
Fix Released
Wishlist
Jacob Appelbaum

Bug Description

Binary package hint: tor

/etc/init.d/tor uses stuff like:
echo "Starting $DESC: $NAME..."
...
echo "done."

instead of

        log_daemon_msg "Starting $DESC" "$NAME"
        ...
        log_end_msg $?

Revision history for this message
Ralf Hildebrandt (ralf-hildebrandt) wrote :

Still there in hardy:
ii tor 0.1.2.19-2 anonymizing overlay network for TCP

Daniel T Chen (crimsun)
Changed in tor:
importance: Undecided → Wishlist
status: New → Confirmed
Changed in tor (Ubuntu):
assignee: nobody → Jacob Appelbaum (jacob-appelbaum)
Revision history for this message
Jacob Appelbaum (jacob-appelbaum) wrote :

How important is this? We're currently discussing the issues upstream.

Revision history for this message
Ralf Hildebrandt (ralf-hildebrandt) wrote :

Is upstream the right place? I mean unless they create ALL the start scripts (SYSV vs upstart), some customization needs to be done by the packaging teams anyway.

How important is this? Well, it is not hard to do, and it looks much nicer :)

Revision history for this message
Jacob Appelbaum (jacob-appelbaum) wrote :

I'm one of the upstream developers and the other upstream developer in the discussion is the main Debian packager. :-)

If you want to write a patch and had a good reason, I think we might accept it - otherwise, I suspect we'd rather not add a new dep (lsb-base) just because it looks pretty.... But if someone writes a patch and tests it, I'm fairly certain that we can make a convincing argument to weasel (the Debian packager/Tor packager in upstream).

I looked into it and it's reasonably straight forward but I'm not going to get around to it in the next few weeks.

Changed in tor (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Daniel Letzeisen (dtl131) wrote :

tor now depends on lsb-base

Changed in tor (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.