OpenStack Heat

resource sql table column 'nova_instance' is misleading

Bug #1346742 reported by Kanagaraj Manickam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Won't Fix
Low
Kanagaraj Manickam

Bug Description

The table resource has a column named 'nova_instance' for storing the uuid for the given resource. Change this to 'physical_resource_id' as it is more generic and representative of what is stored.

NOTE: its discussed in the openstack dev list with subject " [openstack-dev] [heat]Heat Db Model updates".

See original description
Kanagaraj Manickam (kanagaraj-manickam)
Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
summary: - heat db table column Resource 'Rsrc_metadata' to 'metadata'
+ heat db table column Resource schema updates
description: updated
Kanagaraj Manickam (kanagaraj-manickam)
summary: - heat db table column Resource schema updates
+ heat db table Resource schema updates
Revision history for this message
Zane Bitter (zaneb) wrote : Re: heat db table Resource schema updates

You can't change is to 'metadata' because SQLAlchemy model classes already have an attribute named 'metadata'. Just leave it as it is.

Clint Byrum (clint-fewbar)
summary: - heat db table Resource schema updates
+ resource sql table column 'nova_instance' is misleading
description: updated
Changed in heat:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Kanagaraj Manickam (kanagaraj-manickam) wrote :

Thanks, I was suspecting that using metadata name for the column, may not be allowed, but i was not confident about it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/110557

Changed in heat:
status: Triaged → In Progress
Steve Baker (steve-stevebaker)
Changed in heat:
status: In Progress → Triaged
OpenStack Infra (hudson-openstack)
Changed in heat:
status: Triaged → In Progress
Kanagaraj Manickam (kanagaraj-manickam)
Changed in heat:
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/317302

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/110557
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3d173834b18fb84213a6ed91f96c086f1262e9fe
Submitter: Jenkins
Branch: master

commit 3d173834b18fb84213a6ed91f96c086f1262e9fe
Author: Kanagaraj Manickam <email address hidden>
Date: Tue May 17 12:41:29 2016 +0530

    Migrate nova_instance to physical_resource_id

    migrate to physical_resource_id from nova_instance
    at application layer, while the db schema still holds
    nova_instance label. This is the first phase of
    migration. Next patch will take care of db schema.

    Change-Id: I6ebbe3d71d5fb9a7dd3c68ff13777982eb5bbbef
    Partial-bug: #1346742

Rabi Mishra (rabi)
Changed in heat:
milestone: newton-1 → newton-2
Thomas Herve (therve)
Changed in heat:
milestone: newton-2 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Rico Lin (<email address hidden>) on branch: master
Review: https://review.openstack.org/317302
Reason: Hi, this patch stays untouched for few months, would like to abandon for now. Feel free to restore it if you still working on this. Thank you!

Kanagaraj Manickam (kanagaraj-manickam)
Changed in heat:
status: In Progress → Won't Fix
milestone: next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.