MARC order upload form no longer defaults to default fiscal year

Adding a note that we also tested this on a 2.6ish version of master, and the upload form DID default to the fiscal year. However, libraries just started using acq on that server, and all of the funds are 2015 funds (not sure if it is relevant.)

Also, just linking to the bug where this issue was originally fixed https://bugs.launchpad.net/evergreen/+bug/1031927.

I confirmed this behavior within version 2.8.1. Here is what I did:
I performed my fiscal year closeout on 2015. When I did, it created my 2016 funds. Within Acquisitions -> Load MARC Order Records, it is still displaying 2015 as the default fiscal year.

I just remembered that the Load MARC Order Record screen will "remember" the last selections that you made. So, when I selected 2016 as my fiscal year and loaded the records, Evergreen retained the 2016 value the next time I interacted with the interface. However, it does not automatically update to the most recent fiscal year, as Kathy notes.

Marking this bug as a duplicate of bug 1026276. Although that earlier bug was filed before defaulting to a fiscal year was even a feature, it essentially is the same issue.

And I just realized that these are not the same two issues. This one addresses the MARC Order upload form. The other is for the Funds interface. Sorry folks!

I was just looking at http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2b5fc07b79da80c5aaf25103db3df84d543b0a02

We intentionally changed the behavior of that selector so that it would become sticky and default to the previous selection. I may have even been the person who requested that behavior.

At this point, removing those lines from the code don't seem to reinstate the previous behavior of defaulting to the current fiscal year, so there may more work required if an Evergreen site wanted this default.

I would be hesitant to change this behavior right now without adding some additional backend work. Right now, the current behavior is a problem for our libraries because staff become so accustomed to selecting just a few options on this interface before uploading orders, it's very easy to forget to change the fiscal year when a new year starts.

However, since we don't have a way to define different fiscal years for different org units, if a consortium has mixed fiscal years, I could see where it would be frustrating for their libraries to constantly change the fiscal year because they don't fall within the majority.

I think it would be better to address this with development to a feature with OU-specific fiscal years that can be defined from the client. In that manner, we know we are defaulting to a fiscal year that works for the site in question.

This approach, then, would move this report from a bug fix to wishlist.

When we do have OU-specific fiscal year, it would be great if we could also include a prompt that appears after the fiscal year-end process allowing the user to update their fiscal year information.