CI Train [cu2d]

build job in train should check whether built version is higher than in silo

Bug #1353451 reported by Michał Sawicz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
CI Train [cu2d]
Fix Released
Undecided
Robert Bruce Park

Bug Description

When using X-Auto-Uploader: no-rewrite-version, if you don't pay attention, the train might try and upload a version that's already there in the PPA, which will silently fail, 'cause the landers don't get PPA rejection reports.

Ideally the train would forward emails from silos to landers, having first checked that the version it's trying to upload is higher than any in the PPA.

Related branches

lp:~robru/cupstream2distro/upload-phase-version-check
PS Jenkins bot: Approve (continuous-integration)
Robert Bruce Park (community): Approve
Diff: 49 lines (+21/-0)
2 files modified
citrain/build.py (+8/-0)
tests/unit/test_script_build.py (+13/-0)
Cemil Azizoglu (cemil-azizoglu)
Changed in cupstream2distro:
status: New → Confirmed
Robert Bruce Park (robru)
Changed in cupstream2distro:
assignee: nobody → 𝓡𝓸𝓫𝓮𝓻𝓽 𝓑𝓻𝓾𝓬𝓮 𝓟𝓪𝓻𝓴 (robru)
status: Confirmed → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:cupstream2distro at revision 937, scheduled for release in cupstream2distro, milestone Unknown

Revision history for this message
Robert Bruce Park (robru) wrote :

I don't think the train gets the failure emails either, so I'm not aware of any way that we could forward those to landers.

I do however have the ability to check the versions of things before performing uploads, so I've implemented a new check that will loudly fail the build job if the version we're attempting to upload is <= the version that is already in the silo. So there shouldn't be any more surprises when uploading no-rewrite-version packages that silently fail.

Personally however I'd recommend just not using no-rewrite-version, then the train can be smart and bump the version number for you rather than just fail and force you to bump the version number yourself. Saves you work! ;-)

Changed in cupstream2distro:
status: Fix Committed → Fix Released
Revision history for this message
Michał Sawicz (saviq) wrote :

Sure, and that's what we do in 99% of the cases. But the -gles twins packages need the exact same upstream version number to find the upstream tarball.

Failing in the build job is good enough!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.