Designate

Creating a Recordset doesn't increment the serial number

Bug #1361342 reported by Betsy Luzader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Betsy Luzader
Designate 2014.2 "juno"

Bug Description

When a new Recordset is created, if a new record is created, then the serial number usually needs to be incremented. The function needs to be changed from:

    def create_recordset(self, context, domain_id, recordset):

to:

    def create_recordset(self, context, domain_id, recordset, increment_serial=True):

The default value should be set to 'True' and if true, then _increment_domain_serial() should be called. It is handled correctly in update_recordset().

Betsy Luzader (betsy-luzader)
Changed in designate:
importance: Undecided → Critical
Emmanuel Ankutse (emmanuel-ankutse)
Changed in designate:
assignee: nobody → Emmanuel Ankutse (emmanuel-ankutse)
Kiall Mac Innes (kiall)
Changed in designate:
milestone: none → juno-3
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118436

Changed in designate:
assignee: Emmanuel Ankutse (emmanuel-ankutse) → Betsy Luzader (betsy-luzader)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/118436
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=57229e5be65edd845336bdf9aee7658e9db6e6c7
Submitter: Jenkins
Branch: master

commit 57229e5be65edd845336bdf9aee7658e9db6e6c7
Author: Betsy Luzader <email address hidden>
Date: Tue Sep 2 13:50:53 2014 -0500

     Creating a Recordset doesn't increment the serial number

     If a new recordset is created that contains records, most of
     the time the serial number should be incremented. This fixes
     that problem.

     Closes-Bug:#1361342

    Change-Id: Ie5207be43bd30c49914ef1edb960c4bfc58e6892

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.