Missing scope option causes blueprint/launchpad-answers search form to OOPS

Bug #136408 reported by Diogo Matsubara
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Eleanor Berger

Bug Description

Steps to reproduce:
1. Open http://launchpad.dev/specs?field.actions.search=Find+Blueprints&field.scope.target=&field.search_text=foo
2. Crash like: OOPS-607A2039 KeyError 'scope'

It's not possible to construct such query string, unless:
a) you use the web developer firefox extension to clear the radio buttons in the blueprint search form
or
b) you construct the query string manually

That page should:

a) return a UnexpectedFormData or
b) default to "All projects" when the scope key is missing (suggested by Tom Berger);

Changed in blueprint:
assignee: nobody → intellectronica
status: New → Confirmed
Revision history for this message
Eleanor Berger (intellectronica) wrote :

I favour option (b) because this is only likely to be triggered by bots, so why not have them index results from all projects...

Revision history for this message
Eleanor Berger (intellectronica) wrote :

The fix was easy, now writing a test

Changed in blueprint:
status: Confirmed → In Progress
Revision history for this message
Diogo Matsubara (matsubara) wrote :

As seen in OOPS-612A1318. The same issue affects launchpad answers.

Changed in launchpad-answers:
status: New → Confirmed
Revision history for this message
Eleanor Berger (intellectronica) wrote :

Moved the common functionality to the scope widget and used the same fix for answers

Changed in launchpad-answers:
assignee: nobody → intellectronica
status: Confirmed → In Progress
Revision history for this message
Eleanor Berger (intellectronica) wrote :

RF revno. 4893

Changed in blueprint:
status: In Progress → Fix Committed
Changed in launchpad-answers:
status: In Progress → Fix Committed
Changed in blueprint:
status: Fix Committed → Fix Released
Changed in launchpad-answers:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.