grenade fails to upgrade keystone when mod wsgi is enabled

Bug #1365105 reported by Adam Gandelman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Chmouel Boudjnah
grenade
Invalid
Undecided
Unassigned

Bug Description

Working on sideways upgrades within juno. Since icehouse, devstack has enabled mod wsgi services by default, including keystone. Attempting to run grenade within a release fails with a keystone start error:

2014-09-03 05:44:41.967 | Waiting for keystone to start...
2014-09-03 05:44:41.967 | + timeout 120 sh -c 'while ! curl --noproxy '\''*'\'' -k -s http://127.0.0.1:5000/v2.0/ >/dev/null; do sleep 1; done'
2014-09-03 05:46:41.970 | + die 489 'keystone did not start'
2014-09-03 05:46:41.970 | + local exitcode=0
2014-09-03 05:46:41.970 | [Call Trace]

Reproducing locally, I get a connection refused and it looks like /etc/apache2/sites-enabled/keystone.conf is missing. This gets created by devstack's lib/keystone during configure_keystone which grenade's upgrade-keystone does not call (correctly so). However, there is a bug in that devstack lib/keystone stop_keystone() function calls _cleanup_keystone_apache_wsgi(). Grenade does call stop_keystone during stop-base, deleting the original apache config but never re-generating it during upgrade.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to grenade (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118742

Changed in devstack:
status: New → In Progress
Changed in grenade:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on grenade (master)

Change abandoned by Adam Gandelman (<email address hidden>) on branch: master
Review: https://review.openstack.org/118742
Reason: No longer required

Changed in grenade:
status: In Progress → Invalid
Changed in devstack:
assignee: nobody → Chmouel Boudjnah (chmouel)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/118740
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=c4b067134c735b62b3c41105d29f83814abe8f90
Submitter: Jenkins
Branch: master

commit c4b067134c735b62b3c41105d29f83814abe8f90
Author: Adam Gandelman <email address hidden>
Date: Wed Sep 3 11:44:31 2014 -0700

    Split keystone mod wsgi config from start/stop

    We currently cleanup keystone apache config during stop_keystone
    when mod wsgi is enabled, but only create it during initial keystone
    configuration. Grenade expects to be able to stop and start the
    service without reconfiguring it, using only the respective functions.
    This moves cleanup of config from stop_keystone to cleanup_keystone,
    and enables/disables the apache vhost during start/stop.

    Closes-bug: #1365105

    Change-Id: I9e57c9a763fbdb8c5737decfe797ba0e9894150b

Changed in devstack:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.