Icons black in gallery from krillin #45

I reproduced this on desktop: https://www.dropbox.com/s/9mx7qmyzrwqr3o8/Screenshot%202014-09-19%2012.05.07.png?dl=0

Code to reproduce the issue:

import QtQuick 2.2
import Ubuntu.Components 1.1

Rectangle {
    color: "white"
    width: 400
    height: 400

    Icon {
        width: 50
        height: 50
        anchors.centerIn: parent

// name: "select" // works
// source: "select@18.png" // works
        source: "select.png" // breaks
    }
}

code to reproduce the issue below. Save the attached select@18.png in the same directory as this program.

import QtQuick 2.2
import Ubuntu.Components 1.1

Rectangle {
    color: "white"
    width: 400
    height: 400

    Icon {
        width: 50
        height: 50
        anchors.centerIn: parent

// name: "select" // works
// source: "select@18.png" // works
        source: "select.png" // breaks
    }
}

the example code I pasted above gives me this error:

file:///home/tim/dev/ubuntu-ui-toolkit/staging/modules/Ubuntu/Components/Icon10.qml:34:5: QML QQuickImage: Failed to get image from provider: image://scaling/0.444444//home/tim/select@18.png

Shouldn't this be fixed in the gallery app by using name: "select" since that is the correct way of using an icon from the suru icon theme?

Reverting the changes to only Icon10.qml in r1229 will fix the problem.

so, it broke here:

=== modified file modules/Ubuntu/Components/Icon10.qml
--- modules/Ubuntu/Components/Icon10.qml 2014-08-21 13:59:24 +0000
+++ modules/Ubuntu/Components/Icon10.qml 2014-09-02 09:39:09 +0000
@@ -34,42 +34,16 @@
     Image {
         id: image
         objectName: "image"
- anchors.fill: parent
-
- /* Necessary so that icons are not loaded before a size is set. */
- source: ""
- sourceSize {
- width: 0
- height: 0
- }
-
- Component.onCompleted: update()
- onWidthChanged: update()
- onHeightChanged: update()
- Connections {
- target: icon
- ignoreUnknownSignals: true
- onNameChanged: image.update()
- onSourceChanged: image.update()
- }
-
- function update() {
- // only set sourceSize.width, sourceSize.height and source when
- // icon dimensions are valid, see bug #1349769.
- if (width > 0 && height > 0
- && (icon.name || (icon.hasOwnProperty("source") && icon.source))) {
- sourceSize.width = width;
- sourceSize.height = height;
- if (icon.hasOwnProperty("source")) {
- source = icon.source;
- } else {
- source = "image://theme/%1".arg(icon.name);
- }
- } else {
- source = "";
- sourceSize.width = 0;
- sourceSize.height = 0;
- }
+ anchors { top: parent.top; bottom: parent.bottom }
+ fillMode: Image.PreserveAspectFit;
+ sourceSize.height: height
+ source: {
+ if (icon.name)
+ return "image://theme/%1".arg(icon.name);
+ else if (icon.hasOwnProperty("source"))
+ return icon.source;
+ else
+ return "";
         }

         cache: true

Nekhelesh, it is indeed better if gallery-app updates to use the icon theme. Still some apps use icons not in the theme, and gallery-app worked with this code before so the bug needs to be fixed in UITK.

Confirmed that the bug is not present in krillin #72.