description is getting modified when tagging bugs
Bug #138092 reported by
Brian Murray
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-launchpad-bugs |
Fix Released
|
Undecided
|
Markus Korn |
Bug Description
The description of bug reports is getting modified when people are tagging bugs. I tagged bug 135041 as kernel-oops and then received this in an e-mail via the ubuntu-bugs mailing list:
** Description changed:
- TSA kernel: [ 1031.856198] SMP $
+ TSA kernel: [ 1031.856198] SMP$
The "$" is the end of the line in vim. It seems that python-
Related branches
To post a comment you must log in.
The issue seems to be a few things:
1) LP strips trailing spaces and duplicate empty lines when displaying the description, but not when producing the textarea in the "Edit description" page's form.
2) p-lp-b uses the displayed description, not the description from the (other page's) form.
3) p-lp-b does not "know" that its description hasn't been changed, and overwrites the form's description with its internal string in all situations, rather than maintaining some kind "dirty" flag to know when to overwrite the form's description.
#1 is likely not fixable in near-term
#2 is correct if we optimize for speed (though perhaps requests for the description _should_ go fetch it from the form?)
#3 should be fixable, and seems like a reasonable compromise: dropping trailing spaces and dup blanks on an update -- but only when the description actually changes.