Ubuntu Weather App

Newly added locations display strange text rather than city name

Bug #1383042 reported by Pat McGowan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Weather App
Fix Released
Critical
Martin Borho
ubuntu-ui-toolkit (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

Started the weather app, it had two previously defined locations.
I added two new locations, the first displayed a file:// url in the header, the second display "context something"
After restarting the app the strings were correct. Deleting a city and re-adding worked correctly.

I deleted one city then added it back, and the two new cities are reversed, the show each others weather data rather than their own.
Not sure if this is related or needs a separate bug.
Restarting the app again fixed this issue as well.

See original description

Related branches

lp:~martin-borho/ubuntu-weather-app/fix-1383042-location-names
Alan Pope 🍺🐧🐱 🦄 (community): Approve
Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
Diff: 261 lines (+55/-41)
4 files modified
components/AddLocationPage.qml (+0/-1)
components/LocationTab.qml (+1/-1)
po/com.ubuntu.weather.pot (+14/-14)
ubuntu-weather-app.qml (+40/-25)
Pat McGowan (pat-mcgowan)
description: updated
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Still an issue with krillin #140 and com.ubuntu.weather 1.1.377. Cf screenshot.

Revision history for this message
Martin Borho (martin-borho) wrote :

This looks for me like a SDK bug.

Martin Borho (martin-borho)
Changed in ubuntu-weather-app:
assignee: nobody → Martin Borho (martin-borho)
status: New → Confirmed
Revision history for this message
Martin Borho (martin-borho) wrote :

After going back from the location-manager whre the locations where added, a rebuild of the tabs is triggered when clicking "back". There's still a hack in use, to add Tabs dynamically, see here: http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/trunk/view/head:/ubuntu-weather-app.qml#L164

The reload gets triggered here http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/trunk/view/head:/components/LocationManagerPage.qml#L56

This is suboptimal I guess, since this is prone to race conditions somehow....

Revision history for this message
Tim Peeters (tpeeters) wrote :

13:36:21 < t1mp> the header builds the menu using a Repeater on the Tabs and uses the title of each tab, and the menu contents is not created until the tabs button is clicked
13:36:36 < t1mp> so somehow I suspect the Tabs to have wrong titles

Martin Borho (martin-borho)
Changed in ubuntu-weather-app:
status: Confirmed → In Progress
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-weather-app at revision 387, scheduled for release in ubuntu-weather-app, milestone alpha-1

Changed in ubuntu-weather-app:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Invalid
Victor Thompson (vthompson)
Changed in ubuntu-weather-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.