GNOME Integration

Bug #1386958 reported by Tim Lunn
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Lubuntu Software Center
Won't Fix
Wishlist
Unassigned

Bug Description

There is some possibility Ubuntu GNOME will switch to LSC until gnome-software (and its archive backends) are ready.

For that it would be nice to have LSC looking more like a native GNOME app. Joern already added basic GtkHeaderBar support but it needs some tweaking to fit in better. This is just a wishlist to track items that could use attention. Some are just simple tweaks others are more wish list-y

- App title is not normally shown in the gtkheaderbar, since it gets shown in the shell top-bar (App menu)
- There should be a seperator between toolbar and window controls
- background color of toolbar (LSC tabs) doesnt match the headerbar when LSC is focused
- Most (if not all) icons in GNOME app headerbars use symbolic versions
- The toolbar currently requires a fairly large window size or it gets truncated.
- About, Preferences etc are normally linked from the appmenu
- preferences widget could be embedded in a gtk popover and linked to a button (three lines or cog), although in that case it would probably be better to have the toggle activate setting, rather than having apply/cancel buttons.

Related branches

Tim Lunn (darkxst)
description: updated
Revision history for this message
Tim Lunn (darkxst) wrote :

Since you guys probably don't use GNOME. This image shows a pretty good indication of what a native GNOME app would look like.

Splitting up the current toolbar into view switcher/search for example may be a bit too much work (not really looked throughly at your code)

But some of the other things, adding application menu, icons from GNOME symbolic icon set etc, should be fairly easy to implement.

It would probably be worth having a quick look at the GNOME HIG guide, where this image was taken from. Its available in gnome-devel-docs (3.14 only) or https://git.gnome.org/browse/gnome-devel-docs/tree/hig/C (view with yelp)

Revision history for this message
Tim Lunn (darkxst) wrote :

Also after actually looking at the code:

Packing the pre-existing toolbar into the GtkHeaderBar is conceptually wrong, rather the Gtk.Headerbar should become the self.toolbar object, then the individual widgets, packed directly into the headerbar. Doing this would actually solve most of my comments in the initial report.

I will take a quick look at refactoring the code a bit, probably abstracting the toolbar class for the 2 cases. I'm hopeless at GTK+ theming though so might need help there

Revision history for this message
Tim Lunn (darkxst) wrote :
Revision history for this message
Tim Lunn (darkxst) wrote :

With my branch above the only remaining thing that really needs fixing is the appmenu. This in itself is pretty much 2 lines of code and an xml file, but needs lsc to be ported to GtkApplication first.

pop-overs for preferences is not so easy to do with the current structure, unless lubuntu/other DE's also wants to use them.

Changed in lubuntu-software-center:
status: New → Confirmed
status: Confirmed → In Progress
importance: Undecided → Wishlist
Revision history for this message
Simon Quigley (tsimonq2) wrote :

The maintenance of the Lubuntu Software Center is now limited to critical bugfixes on Lubuntu 16.04 only. It has been removed from the archive and does not ship in Lubuntu 17.10 and on. Therefore, I am closing this bug as Won't Fix.

Changed in lubuntu-software-center:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.