PUT on a Recordset with multiple Records results in delete/recreation of all Records

Bug #1396720 reported by Tim Simmons
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Graham Hayes

Bug Description

At the SQLAlchemy level, modifying a recordset with records like so:

records ['101.1.1.1', '1.2.3.4', '1.1.1.1']

PUT /v2/zones/id/recordsets/id

{
    "recordset":{
        "records": [
            '101.1.1.1',
            '1.2.3.4'
         ]
     }
}

Causes the deletion of all three records, and the recreation of the two that would remain.

The SQL queries generated for such a call: http://paste.openstack.org/show/138982/

Tim Simmons (timsim)
description: updated
summary: - PUT on a Recordset with many Recordsresults in delete/recreation of all
+ PUT on a Recordset with many Records results in delete/recreation of all
Records
summary: - PUT on a Recordset with many Records results in delete/recreation of all
- Records
+ PUT on a Recordset with multiple Records results in delete/recreation of
+ all Records
Kiall Mac Innes (kiall)
Changed in designate:
importance: Undecided → High
status: New → Triaged
milestone: none → kilo-1
Changed in designate:
assignee: nobody → Graham Hayes (grahamhayes)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/141887
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=95e824993db148a867ce2eeb839fcb9d90173d53
Submitter: Jenkins
Branch: master

commit 95e824993db148a867ce2eeb839fcb9d90173d53
Author: Graham Hayes <email address hidden>
Date: Mon Dec 15 21:31:10 2014 +0000

    Added smart update of Records Objects in v2

    In the V2 API RRSet PUT operation we now only create /
    delete records that have changed
    Change-Id: I92bca80063f2d5cf4d74f31668f8879aa3c53841
    Closes-Bug: 1396720

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.