Launchpad itself

branch-puller mirror scripts fails with an InvalidURIError

Bug #141527 reported by Diogo Matsubara
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Jonathan Lange

Bug Description

David Allouche indentified an error in the branch-puller mirror script.
Sometimes it might raise an InvalidURIError and that exception is not properly handled.

OOPS-629SMPM692 InvalidURIError "Please update your branch to point to http://jameswestby.net/bzr/builddeb/builddeb.dev/ " is not a valid URI

A log of the error can be found at:
https://pastebin.canonical.com/305/

David patched the production server with:
https://pastebin.canonical.com/304/

Tags: lp-code
Diogo Matsubara (matsubara)
Changed in launchpad-bazaar:
assignee: nobody → ddaa
Revision history for this message
David Allouche (ddaa) wrote :

The gravity of this bug is compounded by a recent regression in the order of pulling branches.

Previously, branches whose mirroring had started but completed (because of an unhandled exception or because the script was killed) on a previous run, were processed last. So branches that caused reproducible unhandled errors would not block other branches from being processed.

Now, a branch that caused an unhandled error on the previous run is processed first on the next run. If the error is reproducible, that effectively brings the service to a halt.

I suspect the regression was introduced in RF 4777, when fixing bug 74031.

Revision history for this message
Jonathan Lange (jml) wrote :

I'm doing some work on getting the puller to download branches in parallel. It will probably be easier if I fix this bug while I'm at it.

Changed in launchpad-bazaar:
assignee: ddaa → jml
importance: Undecided → High
status: New → Triaged
Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: Triaged → In Progress
Revision history for this message
Jonathan Lange (jml) wrote :

Now that we are mirroring branches in subprocesses, InvalidURIError does not terminate the entire branch-puller job.

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
Jonathan Lange (jml) wrote :

The severity of this bug has been reduced, but the puller worker still doesn't actually catch InvalidURIError.

Changed in launchpad-bazaar:
assignee: jml → nobody
importance: High → Medium
milestone: 1.1.10 → 1.1.11
status: Fix Committed → In Progress
Jonathan Lange (jml)
Changed in launchpad-bazaar:
assignee: nobody → jml
Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Revision history for this message
Jonathan Lange (jml) wrote :

InvalidURIError now caught.

Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.