automatic backup every day throws errors

Looks like crontab from cronie doesn't know 'crontab -' to read from standard input but does the same with 'echo "#foo" | crontab'.

Okay, looks like older versions (in Debian) also read from stdin without '-'. So I've changed it.

Rock on, thanks.

Hello,
I have encountered this bug too.
I've tried to apply your patch but it doens't work.

The problem happens instead because the hour is outputted as float so if, for example, I select 12:00 the cron line is:

0 12.0 * * * /usr/bin/nice -n 19 /usr/bin/ionice -c2 -n7 /usr/bin/backintime --backup-job >/dev/null 2>&1

To fix the problem the hour should be converted to int or you can use %i format string like here:

                elif self.CUSTOM_HOUR == backup_mode:
                    cron_line = 'echo "{msg}\n0 ' + self.get_custom_backup_time( profile_id ) + ' * * * {cmd}"'
                elif self.DAY == backup_mode:
                    cron_line = "echo \"{msg}\n%i %i * * * {cmd}\"" % (minute, hour) # <------------------
                elif self.REPEATEDLY == backup_mode:

Best regards,
Tarcisio Fedrizzi.

Hi Tarcisio,

I was already wondering about the float but didn't find the time to track down if there was any reason for this. I changed it as you suggested. Thanks for reporting.

Regards,
Germar

Hi Germar,
the problem arises because the default division operator has been changed in python3.

Here there is an example:

python2
---
+>>> 2 / 3
0
+>>> 2 // 3
0
-----
python3
---
+>>> 2 / 3
0.6666666666666666
+>>> 2 // 3
0

so when on this line:

hour = self.get_automatic_backup_time(profile_id) / 100;

you do the division this means two different things depending on which python you use.

This means that probably the best fix would be to change the row to:

hour = self.get_automatic_backup_time(profile_id) // 100;

Best regards,
Tarcisio.

Hi Tarcisio,

thanks for pointing this out.

Regards,
Germar