Remove old upgrade code
Bug #1420276 reported by
Phill
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Released
|
High
|
Tim Bentley | ||
Bug Description
Added as a bug to remember things to do after 2.2, please add additional tasks:
In plugin/
"This is an old style song, without XML. Let's handle it correctly by iterating through the verses, and then recreating the internal xml object as well."
This code should be removed as we do not support upgrade paths < 2.0.5
-------
In core/common/
"Changed during 1.9.x development."
This code should be removed as we do not support upgrade paths < 2.0.5
Related branches
lp:~trb143/openlp/bugs-2_4b
- Raoul Snyman: Approve
-
Diff: 1230 lines (+351/-312)31 files modifiedopenlp/core/__init__.py (+21/-20)
openlp/core/common/settings.py (+5/-42)
openlp/core/common/uistrings.py (+3/-2)
openlp/core/lib/plugin.py (+1/-7)
openlp/core/lib/serviceitem.py (+1/-6)
openlp/core/ui/advancedtab.py (+13/-0)
openlp/core/ui/mainwindow.py (+13/-17)
openlp/core/ui/plugindialog.py (+11/-11)
openlp/core/ui/printserviceform.py (+1/-1)
openlp/core/ui/thememanager.py (+13/-6)
openlp/plugins/bibles/bibleplugin.py (+5/-3)
openlp/plugins/bibles/lib/db.py (+0/-10)
openlp/plugins/bibles/lib/manager.py (+0/-5)
openlp/plugins/custom/customplugin.py (+2/-4)
openlp/plugins/custom/lib/mediaitem.py (+7/-5)
openlp/plugins/images/imageplugin.py (+1/-24)
openlp/plugins/images/lib/mediaitem.py (+8/-8)
openlp/plugins/presentations/presentationplugin.py (+0/-16)
openlp/plugins/remotes/html/openlp.js (+7/-1)
openlp/plugins/remotes/lib/httprouter.py (+6/-3)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
openlp/plugins/songs/lib/mediaitem.py (+3/-3)
openlp/plugins/songs/lib/openlyricsxml.py (+1/-11)
openlp/plugins/songs/lib/songstab.py (+0/-8)
openlp/plugins/songs/songsplugin.py (+2/-5)
tests/functional/openlp_core/test_init.py (+144/-0)
tests/functional/openlp_core_ui/test_advancedtab.py (+69/-0)
tests/functional/openlp_core_ui/test_mainwindow.py (+2/-2)
tests/functional/openlp_core_utils/test_init.py (+1/-1)
tests/functional/test_init.py (+0/-58)
tests/utils/test_bzr_tags.py (+10/-32)
| Changed in openlp: | |
| importance: | Undecided → Low |
| description: | updated |
| description: | updated |
| description: | updated |
Revision history for this message
| Tim Bentley (trb143) wrote | #1 |
| summary: |
- Remove old upgrade code in plugin/songs/lib/openlyricsxml.py:get_verses + Remove old upgrade code |
| Changed in openlp: | |
| importance: | Low → Wishlist |
| status: | New → Confirmed |
| Changed in openlp: | |
| assignee: | nobody → Tim Bentley (trb143) |
| Changed in openlp: | |
| status: | Confirmed → In Progress |
| importance: | Wishlist → High |
| Changed in openlp: | |
| milestone: | none → 2.3.0 |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| milestone: | 2.3.0 → 2.3.1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
There are a number of other places as well.
ServiceItem ,
ImagePlugin.
Most are tagged with TODOs