pt-upgrade fails on SELECT ... INTO queries
Bug #1421781 reported by
Frank Cizmich
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Frank Cizmich | ||
Bug Description
pt-upgrade fails when a query is of the form SELECT ... INTO
e.g: SELECT 1 INTO @foo
error:
DBD::mysql::st fetchall_arrayref failed: fetch() without execute()
It seems the tool expects the fetchall_array command to succeed (expects 0 or more rows), but the DBI module considers the whole procedure complete, since it's not a "true" SELECT.
PT 2.2.13
DBI version 1.663 (latest as of writing)
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-upgrade-fails-on-SELECT-INTO-queries-1421781
- Daniel Nichter: Approve
-
Diff: 136 lines (+84/-4)4 files modifiedbin/pt-upgrade (+11/-3)
lib/ResultWriter.pm (+3/-1)
t/pt-upgrade/issue_1421781.t (+66/-0)
t/pt-upgrade/samples/select_into.log (+4/-0)
| Changed in percona-toolkit: | |
| status: | New → In Progress |
| milestone: | none → 2.2.14 |
| importance: | Undecided → Medium |
| assignee: | nobody → Frank Cizmich (frank-cizmich) |
| tags: | added: pt-upgrade |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Frank Cizmich (frank-cizmich) wrote | #1 |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Fixed by filtering out SELECT...INTO queries